Finance: increase gas estimate for deposits #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
approved these changes
Sep 9, 2019
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aragon/client#834
The transaction linked in the issue would have worked with 431,885 gas (if all accounting periods were already transitioned, which I assume that was the case given that the gas estimate was 420k). In any case, the real amount of gas that is actually used is lower, but because of DelegateProxy's
FWD_GAS_LIMITthe transaction needs extra gas that is not used. I created an issue on aragonOS to rethink this: aragon/aragonOS#556There's another factor that we are not taking into account in this estimate and that is if the transaction is the first one in the accounting period, 15k more gas are needed as there is an extra slot that is changed from zero to non-zero