Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot deposit organization token into finance #834

Closed
lkngtn opened this issue Jun 12, 2019 · 3 comments · Fixed by aragon/aragon-apps#978
Closed

Cannot deposit organization token into finance #834

lkngtn opened this issue Jun 12, 2019 · 3 comments · Fixed by aragon/aragon-apps#978

Comments

@lkngtn
Copy link

lkngtn commented Jun 12, 2019

Describe the bug
Previously I have been able to deposit an organization token (created via the onboarding or via the CLI) into the finance app.

Attempting to do so results in a failed transaction like the following: https://rinkeby.etherscan.io/tx/0xb0f79a2aad63c2d5621f7dea2e6796ecef77572ae1d8c481040148002fb186b4

Mainnet or testnet?
Rinkeby

Organization
https://rinkeby.aragon.org/#/bg

To Reproduce
Steps to reproduce the behavior:

  1. Go to Tokens > BGST, click on the token badge and copy the token address
  2. Go to Finance and click new transfer
  3. Under token select "Other..."
  4. Copy the address from step one into the token address field.
  5. See available balance, and specify an amount less than current balance.
  6. Add reference and click submit deposit, sign transaction and wait for transaction to fail.

Expected behavior
Should be able to deposit the token into finance.

Screenshots
image

Desktop (please complete the following information):
Chrome + Metamask

Additional context
I've used this workflow in the past without issue, but have repeated this failure on multiple new rinkeby orgs since experiencing this issue.

@lkngtn lkngtn added the bug label Jun 12, 2019
@lkngtn
Copy link
Author

lkngtn commented Jun 12, 2019

I was able to get this to work by manually increasing the Gas Limit in metamask. Will leave this issue open as there seems to be an issue with the gas estimation that would need to still be addressed.

@sohkai
Copy link
Contributor

sohkai commented Jul 3, 2019

Yes... this is likely a problem with our gas estimation and minime tokens :(.

@eternauta1337
Copy link
Contributor

So, I transfered 1 token from one address into another that never had tokens of the org and see that the costs are ~117051 gas.

org: https://nightly-rinkeby.aragon.org/#/0x7D42936F4903A31E486ec575F7D1a58925AfDB3F
token: 0xDa53C1b981E176eE4e8016A37eb7ABcDB5970001
sender: 0xE9C472F2aE592F87841Fa46CeEaB2b4502148693
receiver: 0x9bD2C4271E3fF9bdf7d4AFD6Cda2Dc0c1391e256
tx: https://rinkeby.etherscan.io/tx/0x44de544fb205ba4644a22998837112dbaeb16e2547eedd2273b771c0829e1ff3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants