Agent: add ERC721Receiver support #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sohkai
reviewed
Dec 23, 2019
apps/agent/contracts/Agent.sol
Outdated
| @@ -56,6 +57,7 @@ contract Agent is IERC165, ERC1271Bytes, IForwarder, IsContract, Vault { | |||
| event RemoveProtectedToken(address indexed token); | |||
| event PresignHash(address indexed sender, bytes32 indexed hash); | |||
| event SetDesignatedSigner(address indexed sender, address indexed oldSigner, address indexed newSigner); | |||
| event ReceiveERC721(address indexed token, address operator, address from, uint256 tokenId, bytes data); | |||
There was a problem hiding this comment.
Might as well index the operator and from
apps/agent/contracts/Agent.sol
Outdated
| @@ -35,6 +35,7 @@ contract Agent is IERC165, ERC1271Bytes, IForwarder, IsContract, Vault { | |||
| uint256 public constant PROTECTED_TOKENS_CAP = 10; | |||
|
|
|||
| bytes4 private constant ERC165_INTERFACE_ID = 0x01ffc9a7; | |||
| bytes4 private constant ERC721_RECEIVED = 0x150b7a02; // bytes4(keccak256("onERC721Received(address,address,uint256,bytes)")) | |||
There was a problem hiding this comment.
Maybe rename the variable to ERC721_RECEIVED_INTERFACE_ID to be consistent with the ERC165_INTERFACE_ID.
probot-autolabeler
bot
added
app: finance
app: survey
app: token manager
app: voting
labels
sohkai
added a commit
that referenced
this pull request
Mar 11, 2020
* Agent: add ERC721Receiver support * Lint * Test * Address review comments * cosmetic: small whitespace changes Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com>
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* Agent: add ERC721Receiver support * Lint * Test * Address review comments * cosmetic: small whitespace changes Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1036, see aragonone/product#251
To do: