Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Agent to receive NFTs #251

Closed
4 tasks done
izqui opened this issue Dec 6, 2019 · 3 comments
Closed
4 tasks done

Allow Agent to receive NFTs #251

izqui opened this issue Dec 6, 2019 · 3 comments
Assignees
@izqui
Labels
rocket Related to user advocacy items
Milestone
Sprint 41

Comments

@izqui
Copy link

izqui commented Dec 6, 2019 •
edited by sohkai
Loading

Idea

User story

As as user, I want my Agent to be able to receive NFTs.

This is currently blocking Melon from making their DAO the proper owner of their ENS names (currently they are just managing subdomians with Agent)

Related issues: apps#1036

Technical requirements

  • Easy: Implement ERC721 receiver interface in Agent
  • Complex but future proof: Implement 'Agent callback plugins' so users can 'install functions' on Agent (doing a delegate call depending on the function msg.sig)

Tasks

  • Contract changes
  • Contract deployment
  • aragonPM upgrade (first week of Jan.)
  • A1 blog post (first week of Jan.)
@izqui izqui added the rocket Related to user advocacy items label Dec 6, 2019
@izqui
Copy link
Author

izqui commented Dec 10, 2019

Bumping this up again as Saint Fame also requested support for Agent being able to receive NFTs

@izqui izqui mentioned this issue Dec 18, 2019
Merged
2 tasks
@izqui
Copy link
Author

izqui commented Dec 18, 2019

PR (implementing the easy option): aragon/aragon-apps#1058

@sohkai sohkai added this to the Sprint 41 milestone Dec 18, 2019
@izqui izqui self-assigned this Dec 18, 2019
@sohkai
Copy link

sohkai commented Jan 8, 2020

Decided to not do an aragonPM upgrade at the moment.

@sohkai sohkai closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izqui izqui

Labels
rocket Related to user advocacy items
Projects
None yet
Milestone
Sprint 41
Development

No branches or pull requests
2 participants
@izqui @sohkai