Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent: cannot handle ERC721 NFTs #1036

Closed
sohkai opened this issue Nov 13, 2019 · 1 comment
Closed

Agent: cannot handle ERC721 NFTs #1036

sohkai opened this issue Nov 13, 2019 · 1 comment
Labels
app: agent component: contract

Comments

@sohkai
Copy link
Contributor

sohkai commented Nov 13, 2019

ERC721 tokens require contracts handling them to expose a onERC721Received() method that returns a magic value bytes4(keccak256("onERC721Received(address,address,uint256,bytes)")) on success.

We should upgrade the Agent to support receiving ERC721s.
@izqui izqui mentioned this issue Dec 6, 2019
Closed
4 tasks
@izqui izqui mentioned this issue Dec 18, 2019
Merged
2 tasks
@sohkai
Copy link
Contributor Author

sohkai commented Jan 31, 2020

Closed with #1058.

@sohkai sohkai closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: agent component: contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sohkai