Make Swift 5.2 the minimum requirement #1860

Davidde94 · 2021-05-27T11:02:39Z

Make Swift 5.2 the minimum requirement, dropping support for Swift 5.0 and 5.1.

Motivation:

Whenever we have problems, Swift 5.0 and 5.1 seem to be the culprits. Dropping support for these very old versions will require less maintenance and free up our time to work on new features.

Modifications:

Set the tools version in Package.swift to 5.2
Remove CI configurations for 5.0 and 5.1
Update the various readmes to reflect that this change will be rolled out in NIO 2.30.0

Result:

Swift 5.2 is the minimum version of Swift required to use NIO.

docs/migration-guide-NIO1-to-NIO2.md

Lukasa

This will need to be coordinated with @tomerd to turn off the relevant builders for SwiftNIO.

dev/make-single-file-spm

Davidde94 · 2021-05-27T11:23:51Z

@Lukasa yep! He's in the review list and I'm sending an email

glbrntt

I think a few other things need updating; scripts/build_podspecs.sh and CONTRIBUTING.md.

Also I think we should be able to get rid of the generated tests now and use --enable-test-discovery when it's necessary. Might be easier to do that in a follow up.

weissi · 2021-05-27T12:09:49Z

Also I think we should be able to get rid of the generated tests now and use --enable-test-discovery when it's necessary. Might be easier to do that in a follow up.

Sadly not: https://bugs.swift.org/browse/SR-12008

Davidde94 · 2021-05-27T12:10:17Z

@glbrntt we can't get rid of linux tests right now

Davidde94 · 2021-05-27T12:10:35Z

Nevermind, Johannes beat me :D

glbrntt · 2021-05-27T12:12:13Z

Also I think we should be able to get rid of the generated tests now and use --enable-test-discovery when it's necessary. Might be easier to do that in a follow up.

Sadly not: https://bugs.swift.org/browse/SR-12008

euuuughhhhh 😡😡😡

adam-fowler · 2021-05-28T08:57:37Z

Is the setting of the Package minimum requirements something that should be coordinated with some of the key serverside swift package owners. I doubt any of them want to restrict what version of SwiftNIO their clients can use. Some obvious packages would be AHC, Soto, MongoSwift and RediStack. I think all the Vapor packages have a minimum requirement of 5.2 already.

adam-fowler · 2021-05-28T09:16:10Z

Is the setting of the Package minimum requirements something that should be coordinated with some of the key serverside swift package owners. I doubt any of them want to restrict what version of SwiftNIO their clients can use. Some obvious packages would be AHC, Soto, MongoSwift and RediStack. I think all the Vapor packages have a minimum requirement of 5.2 already.

After talking to @fabianfett offline it appears this isn't an issue. If someone is compiling with Swift 5.2 or later they will pick up later versions of SwiftNIO even though a library in the middle says its minimum requirement is Swift 5.1. Unless that library indicates it wants version 2.30 or later of NIO.

finestructure · 2021-05-31T06:52:58Z

In case you haven't seen the Twitter thread, here's a list of packages in the Swift Package Index that depend on NIO showing their Swift version compatibility as we compute it: https://www.icloud.com/numbers/049dkCvCOid9P8S0UxtCGE3iA#NIO-dependency-check

(Twitter thread)

Note that of the 101 packages (of 298) that are not 5.2+ compatible quite a few are probably only flagged as incompatible because they use OpenSSL and we don't have it installed on our builders. I.e. there's a good chance the impact is smaller than that.

Motivation: - SwiftNIO will soon raise it's minimum supported version of Swift from 5.0 to 5.2 (see: apple/swift-nio#1860) - Swift 5.0 and 5.1 users will not be able to use future versions of NIO (most likely from version 2.30.0). - Since Prometheus depends on NIO and NIO is so pervasive in the ecosystem it makes sense to follow NIOs lead in terms of supported Swift versions. Modifications: - Update Package.swift to change the tools version to 5.2 - Use the newer syntax for specifying target dependencies - Remove Package.resolved since it has little value for libraries - Update circle.yml to update CI jobs - Update Swift version badge in README.md

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

Addressed concerns

fabianfett

🚀🎉

PeterAdams-A

OK, one comment but I don't have a concrete suggestion that's better.

PeterAdams-A · 2021-06-18T15:44:31Z

README.md

 [https://github.com/apple/swift-nio-transport-services][repo-nio-transport-services] <br> first-class support for macOS, iOS, tvOS, and watchOS | `from: "1.0.0"` | `from: "0.1.0"`
 [https://github.com/apple/swift-nio-ssh][repo-nio-ssh] <br> SSH support | `.upToNextMinor(from: "0.2.0")` | _n/a_

+NIO 2.29.0 and older support Swift 5.0+.


Wondering if there is a better way of representing this. 5.0 would work if they did from: 2.0.0

5.0 would work if they did from: anything 2.29.0 and earlier. I think this is probably sufficient.

Davidde94 · 2021-06-18T15:55:49Z

@swift-server-bot test this please

yim-lee · 2021-06-18T19:21:07Z

@swift-nio-bot test this please

Motivation: - SwiftNIO will soon raise it's minimum supported version of Swift from 5.0 to 5.2 (see: apple/swift-nio#1860) - Swift 5.0 and 5.1 users will not be able to use future versions of NIO (most likely from version 2.30.0). - Since Prometheus depends on NIO and NIO is so pervasive in the ecosystem it makes sense to follow NIOs lead in terms of supported Swift versions. Modifications: - Update Package.swift to change the tools version to 5.2 - Use the newer syntax for specifying target dependencies - Remove Package.resolved since it has little value for libraries - Update circle.yml to update CI jobs - Update Swift version badge in README.md Co-authored-by: Jari (LotU) <j.koopman@jarict.nl>

helje5 · 2021-08-31T21:34:43Z

Whenever we have problems, Swift 5.0 and 5.1 seem to be the culprits.

In what ways?

helje5 · 2021-08-31T23:39:49Z

A few issues raised in the Slack:

NIO: implement network interface enumeration for Windows #1647 - just affects building Windows w/ <5.2, no other platforms affected. Windows affected neither, just needs to use 5.2 there
Reduce selector wakeups. #1820 - perf only, could use different compile paths for the two
WebSocket Frame Aggregator #1823 - just a test setup affected, can be worked around

Davidde94 requested review from Lukasa, weissi, tomerd, fabianfett, glbrntt and PeterAdams-A May 27, 2021 11:02

0xTim reviewed May 27, 2021

View reviewed changes

docs/migration-guide-NIO1-to-NIO2.md Outdated Show resolved Hide resolved

Lukasa requested changes May 27, 2021

View reviewed changes

dev/make-single-file-spm Outdated Show resolved Hide resolved

glbrntt previously requested changes May 27, 2021

View reviewed changes

Davidde94 requested review from Lukasa and glbrntt May 27, 2021 12:12

Lukasa approved these changes May 27, 2021

View reviewed changes

glbrntt mentioned this pull request Jun 1, 2021

Update minimum required Swift version to 5.2 swift-server/swift-prometheus#51

Merged

3 tasks

glbrntt mentioned this pull request Jun 8, 2021

Update our allocation counter numbers. apple/swift-nio-http2#290

Merged

Davidde94 and others added 6 commits June 18, 2021 16:30

Swift 5.2

0a2f367

Fix 5.3 typo.

7df348e

Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>

Undo change to setup_swift_pm package

8ec631e

George PR review

137182d

Update check_no_api_breakages.sh

8ce7206

SHASUM comment

d03192c

Davidde94 force-pushed the de/swift-5.2 branch from 20fc9e4 to d03192c Compare June 18, 2021 15:30

fabianfett approved these changes Jun 18, 2021

View reviewed changes

PeterAdams-A approved these changes Jun 18, 2021

View reviewed changes

Use 18.04 for 5.2 CI

ab54010

Davidde94 force-pushed the de/swift-5.2 branch from 798b5e0 to ab54010 Compare June 18, 2021 16:02

Lukasa added the 🆕 semver/minor Adds new public API. label Jun 18, 2021

New API breakage hash

de69f3f

Fix broken TSan

33163ef

Davidde94 merged commit b0effbc into apple:main Jun 18, 2021

Davidde94 deleted the de/swift-5.2 branch June 18, 2021 20:02

Make Swift 5.2 the minimum requirement #1860

Make Swift 5.2 the minimum requirement #1860

Uh oh!

Conversation

Davidde94 commented May 27, 2021

Motivation:

Modifications:

Result:

Uh oh!

Uh oh!

Lukasa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Davidde94 commented May 27, 2021

Uh oh!

glbrntt left a comment

Choose a reason for hiding this comment

Uh oh!

weissi commented May 27, 2021

Uh oh!

Davidde94 commented May 27, 2021

Uh oh!

Davidde94 commented May 27, 2021

Uh oh!

glbrntt commented May 27, 2021

Uh oh!

adam-fowler commented May 28, 2021

Uh oh!

adam-fowler commented May 28, 2021

Uh oh!

finestructure commented May 31, 2021

Uh oh!

fabianfett left a comment

Choose a reason for hiding this comment

Uh oh!

PeterAdams-A left a comment

Choose a reason for hiding this comment

Uh oh!

PeterAdams-A Jun 18, 2021

Choose a reason for hiding this comment

Uh oh!

Lukasa Jun 18, 2021

Choose a reason for hiding this comment

Uh oh!

Davidde94 commented Jun 18, 2021

Uh oh!

yim-lee commented Jun 18, 2021

Uh oh!

helje5 commented Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

helje5 commented Aug 31, 2021

Uh oh!

Uh oh!

helje5 commented Aug 31, 2021 •

edited

Loading