NIO: implement network interface enumeration for Windows #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Sep 24, 2020
compnerd
force-pushed
the
interface-enumeration
branch
from
7a5d81e to
e46f07b
Compare
compnerd
force-pushed
the
interface-enumeration
branch
from
e46f07b to
decd383
Compare
Lukasa
approved these changes
Oct 6, 2020
|
@swift-nio-bot test this please |
|
Sorry @compnerd, seems that 5.0 and 5.1 have a bug where the compiler guards cause the |
compnerd
force-pushed
the
interface-enumeration
branch
2 times, most recently
from
7aea334 to
f8a3780
Compare
Partially implement network interface enumeration. This is sufficient to build up the structures for basic operations. Although the interface information is incomplete, this provides enough structure to continue porting the rest of the NIO interfaces.
compnerd
force-pushed
the
interface-enumeration
branch
from
f8a3780 to
c9d5433
Compare
Lukasa
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implement network interface enumeration. This is sufficient
to build up the structures for basic operations. Although the interface
information is incomplete, this provides enough structure to continue
porting the rest of the NIO interfaces.
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]