Update our allocation counter numbers. #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Jun 8, 2021
| target_repo=${2-"$here/.."} | ||
| tmpdir=$(mktemp -d /tmp/.last-build_XXXXXX) | ||
|
|
||
| for f in swift51 swift52 swift53 swift54 swift55 nightly; do |
There was a problem hiding this comment.
With apple/swift-nio#1860 in mind, should we drop swift51 from this list?
There was a problem hiding this comment.
For now I'd like to keep it: when we make the equivalent PR here, we'll need to remove 51 from this script, just as the linked PR does.
There was a problem hiding this comment.
Should we add swift50 then since we still track allocations for it in http/2?
There was a problem hiding this comment.
Nope, we'll just stop tracking allocs for it.
Motivation: Our 5.5 allocation counts were off. Rather than just update that by hand we should bring over some tooling to do it automatically. Modifications: - Bring over and adapt the update-alloc-limits scripts from NIO. - Run them and commit the updates. Result: CI should pass again.
Lukasa
force-pushed
the
cb-update-alloc-numbers
branch
from
950715a to
a13d068
Compare
glbrntt
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our 5.5 allocation counts were off. Rather than just update that by hand
we should bring over some tooling to do it automatically.
Modifications:
Result:
CI should pass again.