Publisher, Single, Completable onError* operators #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondolo
reviewed
Mar 16, 2021
servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcRouter.java
Outdated
Show resolved
Hide resolved
...alk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/OnErrorResumeCompletable.java
Show resolved
Hide resolved
|
build failure attributed to #999 |
bondolo
approved these changes
Mar 17, 2021
Motivation: ServiceTalk supports a recoverWith operator which allows for error recovery [1]. However the signature of this method is more complex than is often required for simple error recovery, and the name implies "recovery" which is confusing if the return value is intended to propagate an error. [1] http://reactivex.io/documentation/operators/catch.html Modifications: - Add onError* methods to Publisher, Single, and Completable. The signatures are specialized for their respective operation (mapping Throwable, swallowing exceptions, recovering with a value) and also supports filtering by class type and custom Predicate. This naming convention is more commonly used by other JVM based rx implementations and is assumed to be more familiar to users. - Deprecate recoverWith in favor of onErrorResume Result: Publisher, Single, and Completable have onError* operators which provide more APIs tailored toward common error recovery scenarios.
|
build failure attributed to #1200 |
|
build failure attributed to #999 |
|
another failure attributed to #1200 |
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Mar 19, 2021
Motivation: ServiceTalk supports a recoverWith operator which allows for error recovery [1]. However the signature of this method is more complex than is often required for simple error recovery, and the name implies "recovery" which is confusing if the return value is intended to propagate an error. [1] http://reactivex.io/documentation/operators/catch.html Modifications: - Add onError* methods to Publisher, Single, and Completable. The signatures are specialized for their respective operation (mapping Throwable, swallowing exceptions, recovering with a value) and also supports filtering by class type and custom Predicate. This naming convention is more commonly used by other JVM based rx implementations and is assumed to be more familiar to users. - Deprecate recoverWith in favor of onErrorResume Result: Publisher, Single, and Completable have onError* operators which provide more APIs tailored toward common error recovery scenarios.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Jun 21, 2021
Motivation: `recoverWith` operators for `Publisher` and `Single` were deprecated in apple#1435 and can be removed now. Modifications: - Remove `Publisher#recoverWith` Result: No deprecated operators on `Publisher` and `Single` API.
idelpivnitskiy
added a commit
that referenced
this pull request
Jun 23, 2021
Motivation: `recoverWith` operators for `Publisher` and `Single` were deprecated in #1435 and can be removed now. Modifications: - Remove `Publisher#recoverWith` Result: No deprecated operators on `Publisher` and `Single` API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ServiceTalk supports a recoverWith operator which allows for error
recovery [1]. However the signature of this method is more complex than
is often required for simple error recovery, and the name implies
"recovery" which is confusing if the return value is intended to
propagate an error.
[1] http://reactivex.io/documentation/operators/catch.html
Modifications:
signatures are specialized for their respective operation (mapping
Throwable, swallowing exceptions, recovering with a value) and also
supports filtering by class type and custom Predicate. This naming
convention is more commonly used by other JVM based rx implementations
and is assumed to be more familiar to users.
Result:
Publisher, Single, and Completable have onError* operators which provide
more APIs tailored toward common error recovery scenarios.