GracefulConnectionClosureHandlingTest.closeIdleBeforeExchange test failure #1200
Labels
flaky tests
Unit tests are flaky
Comments
|
|
|
https://github.com/apple/servicetalk/runs/1706077633 |
|
https://github.com/apple/servicetalk/runs/2143024608 |
|
https://github.com/apple/servicetalk/runs/2143290414 |
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this issue
Apr 17, 2021
…nge` test Motivation: Client fires `SslHandshakeCompletionEvent` before the server. Therefore, client my already return the reserved connection before server's `ConnectionAcceptor` is invoked. As the result, test may initiate graceful closure before `onClosing` event is registered, leading to the test timeout exception. Modifications: - Use another `CountDownLatch` to wait until server invokes `ConnectionAcceptor` before proceeding to the test scenario; Result: Fixes apple#1200.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this issue
Apr 17, 2021
…nge` test Motivation: Client fires `SslHandshakeCompletionEvent` before the server. Therefore, client my already return the reserved connection before server's `ConnectionAcceptor` is invoked. As the result, test may initiate graceful closure before `onClosing` event is registered, leading to the test timeout exception. Modifications: - Use another `CountDownLatch` to wait until server invokes `ConnectionAcceptor` before proceeding to the test scenario; Result: Fixes apple#1200.
idelpivnitskiy
added a commit
that referenced
this issue
Apr 19, 2021
…nge` test (#1500) Motivation: Client fires `SslHandshakeCompletionEvent` before the server. Therefore, client my already return the reserved connection before server's `ConnectionAcceptor` is invoked. As the result, test may initiate graceful closure before `onClosing` event is registered, leading to the test timeout exception. Modifications: - Use another `CountDownLatch` to wait until server invokes `ConnectionAcceptor` before proceeding to the test scenario; Result: Fixes #1200.
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this issue
Apr 19, 2021
…nge` test (apple#1500) Motivation: Client fires `SslHandshakeCompletionEvent` before the server. Therefore, client my already return the reserved connection before server's `ConnectionAcceptor` is invoked. As the result, test may initiate graceful closure before `onClosing` event is registered, leading to the test timeout exception. Modifications: - Use another `CountDownLatch` to wait until server invokes `ConnectionAcceptor` before proceeding to the test scenario; Result: Fixes apple#1200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
possibly related to #1192 ?
https://ci.servicetalk.io/job/servicetalk-java11-prb/1673/testReport/junit/io.servicetalk.http.netty/GracefulConnectionClosureHandlingTest/closeIdleBeforeExchange_4__protocol_HTTP_1_initiateClosureFromClient_false_useUds_false_viaProxy_true_/
The text was updated successfully, but these errors were encountered: