Fix flaky GracefulConnectionClosureHandlingTest#closeIdleBeforeExchange test
#1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge` test Motivation: Client fires `SslHandshakeCompletionEvent` before the server. Therefore, client my already return the reserved connection before server's `ConnectionAcceptor` is invoked. As the result, test may initiate graceful closure before `onClosing` event is registered, leading to the test timeout exception. Modifications: - Use another `CountDownLatch` to wait until server invokes `ConnectionAcceptor` before proceeding to the test scenario; Result: Fixes apple#1200.
bondolo
approved these changes
Apr 17, 2021
bondolo
pushed a commit
to bondolo/servicetalk
that referenced
this pull request
Apr 19, 2021
…nge` test (apple#1500) Motivation: Client fires `SslHandshakeCompletionEvent` before the server. Therefore, client my already return the reserved connection before server's `ConnectionAcceptor` is invoked. As the result, test may initiate graceful closure before `onClosing` event is registered, leading to the test timeout exception. Modifications: - Use another `CountDownLatch` to wait until server invokes `ConnectionAcceptor` before proceeding to the test scenario; Result: Fixes apple#1200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Client fires
SslHandshakeCompletionEventbefore the server. Therefore,client my already return the reserved connection before server's
ConnectionAcceptoris invoked. As the result, test may initiate gracefulclosure before
onClosingevent is registered, leading to the test timeoutexception.
Modifications:
CountDownLatchto wait until server invokesConnectionAcceptorbefore proceeding to the test scenario;Result:
Fixes #1200.