Add Publisher.timeoutTerminal(Duration) operator #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/TimeoutPublisherTest.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/TimeoutPublisherTest.java
Outdated
Show resolved
Hide resolved
...k-concurrent-internal/src/main/java/io/servicetalk/concurrent/internal/SignalOffloaders.java
Show resolved
Hide resolved
bondolo
force-pushed
the
timeout-publisher
branch
3 times, most recently
from
d2c2c7f to
39d1d49
Compare
bondolo
changed the title
Scottmitch
reviewed
Mar 19, 2021
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/TimeoutPublisherTest.java
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/TimeoutPublisherTest.java
Outdated
Show resolved
Hide resolved
Motivation: The existing Publisher.idleTimeout(Duration) operator resets the timer for each received item. In some cases the entire operation must be completed with a specific amount of time. Modifications: Add a new Publisher operator, withTimeout(Duration, that terminates the Publisher with a TimeoutException if it fails to otherwise terminate before a specified time duration. Result: A new timeout option is available.
bondolo
force-pushed
the
timeout-publisher
branch
from
74ad853 to
0e41826
Compare
idelpivnitskiy
approved these changes
Mar 19, 2021
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/TimeoutPublisher.java
Outdated
Show resolved
Hide resolved
...ncurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/TimeoutPublisherTest.java
Outdated
Show resolved
Hide resolved
Scottmitch
reviewed
Mar 23, 2021
| * @param duration The duration to convert | ||
| * @return The converted nanoseconds value. | ||
| */ | ||
| private long toNanos(Duration duration) { |
There was a problem hiding this comment.
nit: time utility state/methods can be static and likely moved into another class (publisher has many methods so we try to keep it focused on operators).
There was a problem hiding this comment.
OK. I made this change because I notice the Java 11 has it built-in and looking at the implementation realized that overflow handling was needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The existing
Publisher.timeout(Duration)operator restarts the timer for each received item and will only timeout if no items are emitted during the timeout duration. In some cases the total time for all items to be emitted is of more interest. An operator to timeout based on the entire elapsed time since subscribe is needed.Modifications:
Add a new Publisher operator,
timeoutTerminal(Duration), that terminates the Publisher with a TimeoutException if the Publisher does not terminate before the specified time duration.Result:
A new timeout option is available.