Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep release: v1.26.0 #3510

Merged
merged 2 commits into from
Jul 28, 2023
Merged

prep release: v1.26.0 #3510

merged 2 commits into from
Jul 28, 2023

Conversation

o0Ignition0o
Copy link
Contributor

@o0Ignition0o o0Ignition0o commented Jul 28, 2023

Note

When approved, this PR will merge into the 1.26.0 branch which will — upon being approved itself — merge into main.

Things to review in this PR:

  • Changelog correctness (There is a preview below, but it is not necessarily the most up to date. See the Files Changed for the true reality.)
  • Version bumps
  • That it targets the right release branch (1.26.0 in this case!).

🚀 Features

Add coprocessor metrics (PR #3483)

Introduces a new metric for the router:

apollo.router.operations.coprocessor

It has two attributes:

coprocessor.stage: string (RouterRequest, RouterResponse, SubgraphRequest, SubgraphResponse)
coprocessor.succeeded: bool

By @garypen in #3483

Constrain APOLLO_ROUTER_LOG and --log global levels to the router (Issue #3474)

APOLLO_ROUTER_LOG and --log now implicitly set a filter constraining the logging to the apollo_router module, simplifying the debugging experience for users.

For advanced users RUST_LOG can be used for standard log filter behavior.

Thus:

RUST_LOG=apollo_router=warn
--log warn
APOLLO_ROUTER_LOG=warn

are equivalent with all three statements resulting in warn level logging for the router.

For more details, read the logging configuration documentation.

By @garypen in #3477

Add support for PodDisruptionBudget to helm chart (Issue #3345)

A PodDisuptionBudget may now be specified for your router to limit the number of concurrent disruptions.

Example Configuration:

podDisruptionBudget:
  minAvailable: 1

By @garypen in #3469

🐛 Fixes

Fix the pdb template (PR #3497)

Add the required matchLabels: attribute.

By @garypen in #3497

Don't hide --dev from --help (Issue #2705)

Display documentation about --dev when launching the router with --help argument.

By @bnjjj in #3479

Fix prometheus statistics issues with _total_total names(Issue #3443)

When producing prometheus statistics the otel crate (0.19.0) now automatically appends "_total" which is unhelpful.

This fix remove duplicated "_total_total" from our statistics.

By @garypen in #3471

Fix default rhai script dir for Windows (Issue #3401)

Using default rhai.scripts field won't end up in an error.

By @bnjjj in #3411

Fix the prometheus descriptions as well as the metrics (Issue #3491)

I didn't realise the descriptions on the prometheus stats were significant, so my prefious prometheus fix constrained itself to renaming the actual metrics.

This relaxes the regex pattern to include prom descriptions as well as metrics in the renaming.

By @garypen in #3492

🛠 Maintenance

Add a pool idle timeout for subgraph HTTP connectors (Issue #3435)

Having a high idle pool timeout duration can sometimes trigger situations in which an HTTP request cannot complete (see this comment for more information).

This changeset sets a default timeout duration of 5 seconds, which we may make configurable eventually.

By @garypen in #3470

Don't reload the router if the schema/license hasn't changed (Issue #3180)

The router is performing frequent schema reloads due to notifications from uplink. In the majority of cases a schema reload is not required, because the schema hasn't actually changed.

We won't reload the router if the schema/license hasn't changed.

By @bnjjj in #3478

@router-perf
Copy link

router-perf bot commented Jul 28, 2023

CI performance tests

  • xxlarge-request - Stress test with 100 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@o0Ignition0o o0Ignition0o merged commit 3323e41 into 1.26.0 Jul 28, 2023
1 check passed
@o0Ignition0o o0Ignition0o deleted the prep-1.26.0 branch July 28, 2023 10:53
@abernix abernix added release and removed release labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants