Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Features
Add coprocessor metrics (PR #3483)
Introduces a new metric for the router:
It has two attributes:
By @garypen in #3483
Constrain APOLLO_ROUTER_LOG and --log global levels to the router (Issue #3474)
APOLLO_ROUTER_LOG
and--log
now implicitly set a filter constraining the logging to theapollo_router
module, simplifying the debugging experience for users.For advanced users
RUST_LOG
can be used for standard log filter behavior.Thus:
are equivalent with all three statements resulting in
warn
level logging for the router.For more details, read the logging configuration documentation.
By @garypen in #3477
Add support for PodDisruptionBudget to helm chart (Issue #3345)
A PodDisuptionBudget may now be specified for your router to limit the number of concurrent disruptions.
Example Configuration:
By @garypen in #3469
🐛 Fixes
Fix the pdb template (PR #3497)
Add the required
matchLabels:
attribute.By @garypen in #3497
Don't hide
--dev
from--help
(Issue #2705)Display documentation about
--dev
when launching the router with--help
argument.By @bnjjj in #3479
Fix prometheus statistics issues with _total_total names(Issue #3443)
When producing prometheus statistics the otel crate (0.19.0) now automatically appends "_total" which is unhelpful.
This fix remove duplicated "_total_total" from our statistics.
By @garypen in #3471
Fix default rhai script dir for Windows (Issue #3401)
Using default
rhai.scripts
field won't end up in an error.By @bnjjj in #3411
Fix the prometheus descriptions as well as the metrics (Issue #3491)
I didn't realise the descriptions on the prometheus stats were significant, so my prefious prometheus fix constrained itself to renaming the actual metrics.
This relaxes the regex pattern to include prom descriptions as well as metrics in the renaming.
By @garypen in #3492
🛠 Maintenance
Add a pool idle timeout for subgraph HTTP connectors (Issue #3435)
Having a high idle pool timeout duration can sometimes trigger situations in which an HTTP request cannot complete (see this comment for more information).
This changeset sets a default timeout duration of 5 seconds, which we may make configurable eventually.
By @garypen in #3470
Don't reload the router if the schema/license hasn't changed (Issue #3180)
The router is performing frequent schema reloads due to notifications from uplink. In the majority of cases a schema reload is not required, because the schema hasn't actually changed.
We won't reload the router if the schema/license hasn't changed.
By @bnjjj in #3478