Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PodDisruptionBudget to helm chart #3469

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Jul 19, 2023

Example Configuration:

podDisruptionBudget:
  minAvailable: 1

fixes: #3345

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Example Configuration:

```yaml
TBD
```

fixes: #3345
@garypen garypen self-assigned this Jul 19, 2023
@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Jul 19, 2023

CI performance tests

  • xxlarge-request - Stress test with 100 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity

@garypen garypen requested review from a team, Geal, SimonSapin and o0Ignition0o July 19, 2023 09:10
@garypen garypen marked this pull request as ready for review July 19, 2023 09:10
@garypen garypen requested review from BrynCooke and bnjjj and removed request for Geal, SimonSapin and o0Ignition0o July 19, 2023 09:10
@garypen garypen enabled auto-merge (squash) July 19, 2023 09:19
@garypen garypen merged commit e3ea16b into dev Jul 19, 2023
2 checks passed
@garypen garypen deleted the garypen/3345-pdb branch July 19, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the router helm chart should support PodDisruptionBudget configuration
2 participants