-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coprocessor metrics #3483
Add coprocessor metrics #3483
Conversation
Introduces a new metric for the router: ``` apollo.router.operations.coprocessor ``` It has two attributes: ``` coprocessor.stage: string (RouterRequest, RouterResponse, SubgraphRequest, SubgraphResponse) coprocessor.succeeded: bool ``` fixes: apollographql/router-private#177
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion
It has two attributes: | ||
|
||
``` | ||
coprocessor.stage: string (RouterRequest, RouterResponse, SubgraphRequest, SubgraphResponse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit. Would be nice if these names matched the other use in the metrics naming.
e.g.
router.request
, router.response
etc rather than CamelCase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should monitor this and make the change in a followup PR if it seems sensible. Right now, the values are set to match the exact values transmitted in the coprocessor protocol. It would be nice to have some user feedback before changing.
Introduces a new metric for the router:
It has two attributes:
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Ran a router with all coprocessor stages enabled and prometheus enabled. Sent in a request to generate a success metric. Then stopped the coprocessor and sent in another request to generate a fail metric. Examined the prometheus metrics to ensure they were as expected. e.g.:
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test