ApolloServer hangs if middleware configuration promise is rejected #23
Labels
Comments
|
Just for reference, this bug also exists "upstream" in express-graphql. |
|
@helfer should we build a test for this in the core-refactor branch? |
|
@nnance good point. I just added a test. |
evans
pushed a commit
that referenced
this issue
Jul 3, 2018
evans
added a commit
that referenced
this issue
Jul 3, 2018
* Initial commit * Add .npmignore to avoid ignoring lib when publishing * 0.0.2 * Update graphql-extensions dependency to 0.0.2 * 0.0.3 * Reorganize code and add tests * 0.0.4 * Add tests and reorganize code * 0.0.5 * Update dependency to graphql-extensions 0.0.4 * 0.0.6 * Update graphql-extensions dependency and downgrade TS target * 0.0.7 * Update README * Update README * Update README * Update README * Add import instructions for TypeScript to README (#7) * Add cache hints when the directive is defined on interfaces (#10) * Increase version range for `graphql` peerDependency. (#12) * 0.0.8 * Update dependencies * 0.0.9 * [apollo-bot] Update the Issue/PR Templates with auto label (#13) * [apollo-bot] Update the Templates with docs label (#15) * Add cache hints to info.cacheControl (#16) This exposes the `cacheControl` hints on the schema, to the resolvers at runtime. * Update `graphql` peer dependency range to allow 0.13.x. * dev: Update TypeScript to latest version, v2.7.2. * dev: Update jest & dependencies to latest versions. * dev: Update type definitions for `graphql`, `node` and `jest`. * dev: Update `graphql` to latest version, v0.13.2. * 0.0.10 * Add defaultMaxAge option This is an easy way to quickly say "I want everything in my schema to be cached for 5 seconds". You can override it with specific maxAges on specific fields or types. An upcoming release of apollo-server-* will allow you to specify options to cacheControl. * Add CircleCI config * Add partial CHANGELOG * 0.1.0 * Honor overwrite default maxAge with maxAge=0 (Fixes #22) (#23) * 0.1.1 * Allow default caching to apply to interfaces * remove unused files * update versions and use a-s style config * run prettier * fix tests and typing
trevor-scheer
pushed a commit
that referenced
this issue
May 6, 2020
…ist`. (#23) Since we've moved the `apollo-graphql` package from `apollo-server` to `apollo-tooling`, it's now subjected to the new TypeScript compilation rules for that repository. (See: apollographql/apollo-tooling#1018) Those compilation rules differ slightly and put their output in the `lib` directory rather than the `dist` directory. In an ideal world, we'd fix that at publish time so the actual `outDir` didn't matter (i.e. we could actually publish from the `dist/` directory, something which `lerna` actually supports!), but for now, changing this import should be good. I'd intentionally not done this before (and instead just pinned the version exactly to a version which I knew was still utilizing the previous `dist/` compilation `outDir`) as we'd been waiting for the first publish to occur from that repository, but that publish has now happened and Renovate has come through and updated it so it's time to make the change more permanently! Follows-up: https://github.com/apollographql/apollo-platform-commercial/pull/10
trevor-scheer
pushed a commit
that referenced
this issue
May 12, 2020
…ist`. (#23) Since we've moved the `apollo-graphql` package from `apollo-server` to `apollo-tooling`, it's now subjected to the new TypeScript compilation rules for that repository. (See: apollographql/apollo-tooling#1018) Those compilation rules differ slightly and put their output in the `lib` directory rather than the `dist` directory. In an ideal world, we'd fix that at publish time so the actual `outDir` didn't matter (i.e. we could actually publish from the `dist/` directory, something which `lerna` actually supports!), but for now, changing this import should be good. I'd intentionally not done this before (and instead just pinned the version exactly to a version which I knew was still utilizing the previous `dist/` compilation `outDir`) as we'd been waiting for the first publish to occur from that repository, but that publish has now happened and Renovate has come through and updated it so it's time to make the change more permanently! Follows-up: https://github.com/apollographql/apollo-platform-commercial/pull/10
trevor-scheer
pushed a commit
that referenced
this issue
May 14, 2020
…ist`. (#23) Since we've moved the `apollo-graphql` package from `apollo-server` to `apollo-tooling`, it's now subjected to the new TypeScript compilation rules for that repository. (See: apollographql/apollo-tooling#1018) Those compilation rules differ slightly and put their output in the `lib` directory rather than the `dist` directory. In an ideal world, we'd fix that at publish time so the actual `outDir` didn't matter (i.e. we could actually publish from the `dist/` directory, something which `lerna` actually supports!), but for now, changing this import should be good. I'd intentionally not done this before (and instead just pinned the version exactly to a version which I knew was still utilizing the previous `dist/` compilation `outDir`) as we'd been waiting for the first publish to occur from that repository, but that publish has now happened and Renovate has come through and updated it so it's time to make the change more permanently! Follows-up: https://github.com/apollographql/apollo-platform-commercial/pull/10
trevor-scheer
pushed a commit
that referenced
this issue
May 14, 2020
…ist`. (#23) Since we've moved the `apollo-graphql` package from `apollo-server` to `apollo-tooling`, it's now subjected to the new TypeScript compilation rules for that repository. (See: apollographql/apollo-tooling#1018) Those compilation rules differ slightly and put their output in the `lib` directory rather than the `dist` directory. In an ideal world, we'd fix that at publish time so the actual `outDir` didn't matter (i.e. we could actually publish from the `dist/` directory, something which `lerna` actually supports!), but for now, changing this import should be good. I'd intentionally not done this before (and instead just pinned the version exactly to a version which I knew was still utilizing the previous `dist/` compilation `outDir`) as we'd been waiting for the first publish to occur from that repository, but that publish has now happened and Renovate has come through and updated it so it's time to make the change more permanently! Follows-up: https://github.com/apollographql/apollo-platform-commercial/pull/10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It should provide a useful error message instead.
The text was updated successfully, but these errors were encountered: