Apply Resolvers to JS schema in apolloServer #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return request(app).get( | ||
| '/graphql?query={stuff useTestConnector species(name: "uhu")}' | ||
| ).then((res) => { | ||
| return expect(res.body.data).to.deep.equal(expected); |
There was a problem hiding this comment.
I think this doesn't actually do what one would expect, because the mocks interfere with resolvers. There's another PR open for that, but until that's merged, this test will actually use the mocks, and not the resolvers (the coveralls coverage report also seems to indicate that the new added line is never executed).
I think for the purposes of this test, it would be enough to just test a single field with the following query: { species(name: 'uhu') } and make sure it returns the expected value (which is ROOTuhu). You can remove the mocks completely.
|
@nnance: After you change the test, make sure to check out the coveralls report. It will tell you which lines of the code are tested, which is super useful and has saved me a couple of times when I thought I tested something, but the coverage report showed that i didn't actually test it. You can also look at it locally if you want, the coverage reports go into the |
|
Also, I just merged another PR, so we should rebase this one on the most recent head on master. |
nnance
force-pushed
the
js-schema-resolvers
branch
from
3499761 to
4cf9067
Compare
|
@helfer this is ready for another review |
|
@nnance Thanks, this looks good now! |
martijnwalraven
pushed a commit
that referenced
this pull request
Jun 27, 2018
) In some cases, it's conceivable that the `format()` method may need to abort its decision to provide extension information at runtime, in the event that it doesn't have the proper information to return a full-result. The `format` method already removed false-y results, so this simply changes the types to allow the same.
evans
pushed a commit
that referenced
this pull request
Jun 27, 2018
…rver-env (#1259) * Export polyfills and types separately * More imports from apollo-server-env * Initial commit * Add .npmignore to avoid ignoring lib when publishing * 0.0.2 * Reorganize code and clean up GraphQLExtension interface * 0.0.3 * Add support for timing callbacks and add GraphQLExtensionStack * 0.0.4 * Downgrade target in tsconfig.json from es2015 to es5 * 0.0.5 * Bump `graphql` peerDependency. (#3) * 0.0.6 * Update dependencies * 0.0.7 * whenResultIsFinished fix for array results (#4) * 0.0.8 * [apollo-bot] Update the Issue/PR Templates with auto label (#6) * Bump `graphql` peerDependency. (#7) * Update `graphql` peer dependency range to allow 0.13.x. (#8) * Update `devDependencies` to latest versions. (#9) * dev: Update TypeScript to latest version, v2.7.2. * dev: Update `graphql` to latest version, v0.13.2. * dev: Update jest & dependencies to latest versions. * dev: Update type definitions for `graphql`, `node` and `jest`. * Allow `undefined` return values to `GraphQLExtension`'s `format()`. (#10) In some cases, it's conceivable that the `format()` method may need to abort its decision to provide extension information at runtime, in the event that it doesn't have the proper information to return a full-result. The `format` method already removed false-y results, so this simply changes the types to allow the same. * 0.0.9 * Fix lifecycle method invocations on extensions * 0.0.10 * Add changelog * Upgrade to TypeScript 2.8 Makes my editor integration happier (a bugfix in tsserver I think) * Add tslint and prettier Same configuration as apollo-engine-js * Remove magic from GraphQLExtensionStack constructor It's not hard to consistently pass in an actual extension object to this low-level API. * New extension API: didStart handlers return didEnd handlers This is a backwards-incompatible change: GraphQLExtension implementations and users of GraphQLExtensionStack (ie apollo-server-core) must change their implementations, if they implement any of the xDidStart/xDidEnd APIs. This allows "didEnd" handlers to refer to closure variables from the "didStart" handler rather than needing to store state on the extension. The new "didEnd" handlers run in the opposite order of the "didStart" handlers, so that they properly nest. * 0.1.0-beta.0 * Changelog * Add magic back into GraphQLExtensionStack constructor But now it actually gets more context (the execution arguments) and doesn't have to be a constructor. * 0.1.0-beta.1 * Export more types * 0.1.0-beta.2 * Fix lifecycle handlers to pass proper "this" * 0.1.0-beta.3 * Pass options directly to start handlers; eliminate factory again * 0.1.0-beta.4 * error handling in didEnd * 0.1.0-beta.5 * pass multiple errors to EndHandler * 0.1.0-beta.6 * add willSendResponse * 0.1.0-beta.7 * prettier * setFieldResolver for custom fieldResolver * reverse * get more initial options into requestDidStart * 0.1.0-beta.8 * 0.1.0-beta.9 * Actually, we already get the fieldResolver! * 0.1.0-beta.10 * work without extensionStack * 0.1.0-beta.11 * 0.1.0-beta.12 * Send errors to willResolveField callback * 0.1.0-beta.13 * willSendResponse can return a result * 0.1.0-beta.14 * Revert 1063be8..56912fc This reverts commit 1063be8..56912fc. * add PQ options to requestDidStart * 0.1.0-beta.14 * 0.1.0-beta.15 * Initialize an empty TypeScript/Jest package Template based on apollo-engine-js * Basic trace node structure building * basic timing * Checkpoint towards signature implementation The new signature implementation does not try to compress whitespace. * Basic signature implementation * progress towards actual reporting * basic checkpoint for reporting * 0.0.0-beta.1 * pull in @types/long, since it is in the external api * 0.0.0-beta.2 * get rid of Long * 0.0.0-beta.3 * debug log request what happened * 0.0.0-beta.4 * 0.0.0-beta.5 * correct url * 0.0.0-beta.6 * request headers * 0.0.0-beta.7 * leave out a few headers * 0.0.0-beta.8 * prettier * move stuff into multiple files, and stop exporting the extension * lots of doc comments * address agent.ts XXX comments * implement privateVariables simplify API by removing flush() and allowing flush-ers to just call sendReport directly * privateHeaders and error tracking * gzip, signals * fix test * 0.0.0-beta.9 * Error handling for reports * 0.0.0-beta.10 * no need to include boring stacktrace * 0.0.0-beta.11 * tweak error reporting * 0.0.0-beta.12 * package-lock update (npm@6?) * Reduce target report size to 512KB from 4MB. Load testing revealed that protobuf encoding for large FullTraceReports could tie up CPU and reduce p99 request latency (eg, to 200ms from 10ms). Reducing the default target report size spreads out the encoding time and mitigates the impact on latency. If this is not acceptable for all users, we may have to investigate reintroducing agent-side stats aggregation to keep report sizes small. * 0.0.0-beta.13 * Encode Traces as they come in This improves p99 times with little effect on p50 times. It also lets us get rid of the heuristic average trace size estimation. * 0.0.0-beta.14 * support PQ fields * npm audit fix * 0.0.0-beta.15 * ignore coverage * Make the default signature more aggressive We'd rather tell people confused by literal removal to tweak the signature than tell people causing outages to do so. * 0.0.0-beta.16 * Remove obsolete files from graphql-extensions and apollo-engine-reporting * Fix dependencies and configs * Fix apollo-server-cloudflare to import from apollo-server-env * Fix compilation and test configs * Get all tests passing again * Switch to Lerna independent versioning * Polyfill promisify for Node < 8 and load polyfills in tests * ES2016 exponentiation operator is only supported in Node > 6 * add dependency cache for circle * add missing env dependencies in REST datasource
evans
pushed a commit
that referenced
this pull request
Jul 3, 2018
evans
added a commit
that referenced
this pull request
Jul 3, 2018
* Initial commit * Add .npmignore to avoid ignoring lib when publishing * 0.0.2 * Update graphql-extensions dependency to 0.0.2 * 0.0.3 * Reorganize code and add tests * 0.0.4 * Add tests and reorganize code * 0.0.5 * Update dependency to graphql-extensions 0.0.4 * 0.0.6 * Update graphql-extensions dependency and downgrade TS target * 0.0.7 * Update README * Update README * Update README * Update README * Add import instructions for TypeScript to README (#7) * Add cache hints when the directive is defined on interfaces (#10) * Increase version range for `graphql` peerDependency. (#12) * 0.0.8 * Update dependencies * 0.0.9 * [apollo-bot] Update the Issue/PR Templates with auto label (#13) * [apollo-bot] Update the Templates with docs label (#15) * Add cache hints to info.cacheControl (#16) This exposes the `cacheControl` hints on the schema, to the resolvers at runtime. * Update `graphql` peer dependency range to allow 0.13.x. * dev: Update TypeScript to latest version, v2.7.2. * dev: Update jest & dependencies to latest versions. * dev: Update type definitions for `graphql`, `node` and `jest`. * dev: Update `graphql` to latest version, v0.13.2. * 0.0.10 * Add defaultMaxAge option This is an easy way to quickly say "I want everything in my schema to be cached for 5 seconds". You can override it with specific maxAges on specific fields or types. An upcoming release of apollo-server-* will allow you to specify options to cacheControl. * Add CircleCI config * Add partial CHANGELOG * 0.1.0 * Honor overwrite default maxAge with maxAge=0 (Fixes #22) (#23) * 0.1.1 * Allow default caching to apply to interfaces * remove unused files * update versions and use a-s style config * run prettier * fix tests and typing
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 12, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding resolvers to JS Schema