Skip to content

Commit

Permalink
Switch apollo-graphql path-based import to use lib rather than `d…
Browse files Browse the repository at this point in the history
…ist`. (#23)

Since we've moved the `apollo-graphql` package from `apollo-server` to
`apollo-tooling`, it's now subjected to the new TypeScript compilation rules
for that repository.

(See: apollographql/apollo-tooling#1018)

Those compilation rules differ slightly and put their output in the `lib`
directory rather than the `dist` directory.  In an ideal world, we'd fix
that at publish time so the actual `outDir` didn't matter (i.e. we could
actually publish from the `dist/` directory, something which `lerna`
actually supports!), but for now, changing this import should be good.

I'd intentionally not done this before (and instead just pinned the version
exactly to a version which I knew was still utilizing the previous `dist/`
compilation `outDir`) as we'd been waiting for the first publish to occur
from that repository, but that publish has now happened and Renovate has
come through and updated it so it's time to make the change more
permanently!

Follows-up: https://github.com/apollographql/apollo-platform-commercial/pull/10
  • Loading branch information
abernix authored Mar 5, 2019
1 parent 80edab6 commit bf9d558
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import {
printWithReducedWhitespace,
sortAST,
} from 'apollo-graphql/dist/transforms';
} from 'apollo-graphql/lib/transforms';

export const envOverrideOperationManifest =
'APOLLO_OPERATION_MANIFEST_BASE_URL';
Expand Down

0 comments on commit bf9d558

Please sign in to comment.