Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Edit Chart): mixed time series chart: The secondary y-axis title is disguised/misplaced #25168

Conversation

webobite
Copy link

@webobite webobite commented Sep 3, 2023

SUMMARY

Fix(Edit Chart): mixed time series chart: The secondary y-axis title is disguised/misplaced

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

This fix is for the following issue raised: #18235
Pls feel free to share your feedback for the same.
Before Change:
Scenario 1:
Scenario 2:
image

After change :
As per the control change for Y-Axis Title Position, The y-axis title should be displayed to the Left or top.
As I can see It has a single control for Primary Y Axis Title Position control.
something like this: -
I made the change on my local and was able to come up with these scenarios
Scenario 1 :
image
Scenario 2:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
    Thanks and Regard
    Subham (webobite)

…che#18235 - Linked the yAxisTitlePosition control for the secondary Y axis too
@webobite webobite changed the title [mixed time-series] #18235 Secondary y axis title is disguised / misplaced fix(Edit Chart): mixed time series chart: The secondary y-axis title is disguised/misplaced Sep 3, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@justinpark
Copy link
Member

justinpark commented Sep 7, 2023

@webobite Thanks for the update. Since one control changes the both orientation, could you change the label "Left" to something generic term like "Side" instead?

And please also add the migration script for the updated orientation value.

@webobite
Copy link
Author

Sure Let me check the same, For the Migration script Where to find the some heads-up docs for the same. @justinpark

@sfirke
Copy link
Member

sfirke commented Nov 22, 2023

This is a great improvement, thank you @webobite ! Do you need guidance to make the changes requested by @justinpark ?

@geido
Copy link
Member

geido commented Feb 23, 2024

Thanks. This was fixed here apache-superset/superset-ui#1351

@geido geido closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants