Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-echarts): add x and y label support for 9 charts #1351

Merged

Conversation

MaxHuiYYDS
Copy link
Contributor

@MaxHuiYYDS MaxHuiYYDS commented Sep 7, 2021

fix #16512

🏆 Enhancements
This PR supports two features:
1 User can add X/Y axis label in below chart:
time series line chart,
time series area chart,
time series bar chat,
time series scatter plot,
mix time series,
time series chart,
time series smooth line,
time series stepped line,
box plot.
2 Changed previews default top Y axis position to dynamic left/top choice.
related to:
apache/superset#16512

After:

Screen.Recording.2021-09-07.at.8.56.51.AM.mov

@MaxHuiYYDS MaxHuiYYDS requested a review from a team as a code owner September 7, 2021 00:35
@vercel
Copy link

vercel bot commented Sep 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/DriSQ7pcHkzvw9jeMUbRK5AdMgYC
✅ Preview: https://superset-ui-git-fork-maxhuiyyds-feat-timeseries-1d76d8-superset.vercel.app

@MaxHuiYYDS
Copy link
Contributor Author

@junlincc @stephenLYZ please help me review this PR, :)

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #1351 (9ab5825) into master (779b942) will increase coverage by 0.06%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
+ Coverage   30.03%   30.09%   +0.06%     
==========================================
  Files         489      491       +2     
  Lines        9856     9875      +19     
  Branches     1654     1663       +9     
==========================================
+ Hits         2960     2972      +12     
- Misses       6655     6658       +3     
- Partials      241      245       +4     
Impacted Files Coverage Δ
plugins/plugin-chart-echarts/src/BoxPlot/types.ts 0.00% <ø> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 80.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 50.00% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 50.00% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 50.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 40.00% <ø> (ø)
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 40.00% <ø> (ø)
...ugins/plugin-chart-echarts/src/Timeseries/types.ts 100.00% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779b942...9ab5825. Read the comment docs.

@MaxHuiYYDS MaxHuiYYDS changed the title feat(plugin-chart-echarts): add x and y label support for timeseries feat(plugin-chart-echarts): add x and y label support for 9 charts Sep 7, 2021
Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants