Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixed time-series] Secondary y-axis title is disguised/misplaced #18235

Closed
3 tasks done
rumbin opened this issue Jan 31, 2022 · 7 comments
Closed
3 tasks done

[mixed time-series] Secondary y-axis title is disguised/misplaced #18235

rumbin opened this issue Jan 31, 2022 · 7 comments
Assignees
Labels
#bug Bug report

Comments

@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2022

The Mixed Time-Series chart type allows for configuring the title of the primary and the secondary y-axis.
However, while only the title of the primary axis is shown next to the axis, the title of the secondary one is placed at the upper end of the axis where it gets hidden by bar values and zoom controls.

How to reproduce the bug

  1. Create a mixed time-series chart
  2. Configure axis titles for both y-axes
  3. Check the Data Zoom checkbox

Expected results

Both axes carry the titles as configured

Actual results

Only the left/primary y-axis has a title shown at the center of the axis.
The title of the right/secondary axis is misplaced at the end of the axis and thus overprinted/disquised by bar values and/or zoom controls.

Screenshots

mixed_time-series_y2_title

Environment

  • browser type and version: Chrome 96.0.4664.93
  • superset version: 1.4.0
  • all other versions: as defined in Superset's Docker image
  • Feature flags:
# stable:
      "THUMBNAILS": True,
      "SQLLAB_BACKEND_PERSISTENCE": True,
      "ENABLE_TEMPLATE_PROCESSING": True,
      "DASHBOARD_CROSS_FILTERS": True,

      # experimental:
      "ALERT_REPORTS": True,
      "ALERTS_ATTACH_REPORTS": True,
      "DASHBOARD_NATIVE_FILTERS": True,

      # unclassified:
      "ENABLE_EXPLORE_DRAG_AND_DROP": True,
      "ENABLE_DND_WITH_CLICK_UX": True,

      # development:
      "DASHBOARD_NATIVE_FILTERS_SET": True

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@rumbin rumbin added the #bug Bug report label Jan 31, 2022
@geido geido added validation:validated A committer has validated / submitted the issue or it was reported by multiple users good first issue Good first issues for new contributors preset:cares Preset cares about this issue labels Feb 1, 2022
@villebro
Copy link
Member

villebro commented Feb 8, 2022

Repro'd - I started working on a fix but I identified multiple inconsistencies in this area, so will need to circle back slightly later due to lack of time right now.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@rumbin
Copy link
Contributor Author

rumbin commented Apr 16, 2022

This issue should not be closed by the stale bot, in my eyes.

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 16, 2022
@vaibhav-malpani
Copy link

Any updates on this?
We are using mixed-time series on our dashboard.. and this issue really does not look good.

@srikary12
Copy link

Can someone help me with the file.

@webobite
Copy link

webobite commented Sep 2, 2023

Hi @rumbin / @srikary12 / @vaibhav-malpani ,

What should the expectation be? (Both axes carry the titles as configured)
As per the control change for Y-Axis Title Position, The y-axis title should be displayed to the Left or top.
As I can see It has a single control for Primary Y Axis Title Position control.
something like this: -
I made the change on my local was able to come up with these scenerios
Scenario 1 :
image
Scenario 2:
image

webobite added a commit to webobite/superset that referenced this issue Sep 2, 2023
…che#18235 - Linked the yAxisTitlePosition control for the secondary Y axis too
@geido geido removed validation:validated A committer has validated / submitted the issue or it was reported by multiple users preset:cares Preset cares about this issue good first issue Good first issues for new contributors labels Feb 23, 2024
@geido
Copy link
Member

geido commented Feb 23, 2024

Fixed by apache-superset/superset-ui#1351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

6 participants