-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Imporve][Fake-Connector-V2]support user-defined-schmea and random data for fake-table #2406
Conversation
...ector-fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeData.java
Outdated
Show resolved
Hide resolved
...ector-fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeData.java
Outdated
Show resolved
Hide resolved
I find |
the PR has completed. I add Junit5-test and test random data correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the connectors-v2/FakeSource docs?
...l-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf
Outdated
Show resolved
Hide resolved
...l-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf
Outdated
Show resolved
Hide resolved
...l-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf
Outdated
Show resolved
Hide resolved
...l-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf
Outdated
Show resolved
Hide resolved
...fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeRandomData.java
Outdated
Show resolved
Hide resolved
...fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeRandomData.java
Outdated
Show resolved
Hide resolved
...fake/src/main/java/org/apache/seatunnel/connectors/seatunnel/fake/source/FakeRandomData.java
Outdated
Show resolved
Hide resolved
...-e2e/seatunnel-flink-connector-v2-e2e/src/test/resources/assertion/fakesource_to_assert.conf
Outdated
Show resolved
Hide resolved
here https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2/source |
yes , I update the config to keep the schema parameters consistent such as LocalFile and HDFS source. |
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/src/test/resources/jdbc/fakesource_to_jdbc.conf
Outdated
Show resolved
Hide resolved
...-e2e/seatunnel-flink-connector-v2-e2e/src/test/resources/assertion/fakesource_to_assert.conf
Show resolved
Hide resolved
LGTM |
…ta for fake-table (apache#2406) * [Connector-V2][JDBC-connector] optimization fake Co-authored-by: tangjiafu <tangjiafu@corp.netease.com>
Purpose of this pull request
the connector-v2-fake did't not support enough data type, and not quickly to modify,more time we need the fake to test the dataType Mapper,
so I do these works:
(1) optimization connector-fake-v2 so that we can easy to add column name,type and data
(2) change the spark example for connector-fake-v2,and fix some dead Http link in this example conf file
(3) I find the method don't contain the condition SqlType=NULL: org.apache.seatunnel.translation.serialization.RowConverter#validate,I don't sure it OK。and the SqlType of VOID_TYPE is NULL
(4) the error message is bad in org.apache.seatunnel.translation.serialization.RowConverter(line 60), i fix it
Check list
New License Guide