-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Add sentry sink connector #2244 #2584
Conversation
# Conflicts: # plugin-mapping.properties # seatunnel-connectors-v2-dist/pom.xml # seatunnel-connectors-v2/pom.xml
<dependency> | ||
<groupId>io.sentry</groupId> | ||
<artifactId>sentry-logback</artifactId> | ||
<version>5.0.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We manage dependencies uniformly in the root pom (dependency managernt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hi, great, could you add some pictures of the corresponding test results? I don't have the corresponding environment |
|
# This is a example source plugin **only for test and demonstrate the feature source plugin** | ||
FakeSource { | ||
result_table_name = "fake" | ||
field_name = "name,age" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merged dev branch? FeakSource updated schema format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test all datatypes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i should remove the example code? i didn't see other connector commit the example code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i should remove the example code?
it's OK to me.
BTW, I'm not sure if it's appropriate for the sink to write directly to SeatunelRow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,i've remove the example class and conf file and pom dependency.
...ry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySinkWriter.java
Show resolved
Hide resolved
… doc, remove example class
Finish updating doc. |
Document is ok. |
…#2584) * [Feature][Connector-V2] Add sentry sink connector apache#2244 * [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
…#2584) * [Feature][Connector-V2] Add sentry sink connector apache#2244 * [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
…#2584) * [Feature][Connector-V2] Add sentry sink connector apache#2244 * [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
…#2584) * [Feature][Connector-V2] Add sentry sink connector apache#2244 * [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
…#2584) * [Feature][Connector-V2] Add sentry sink connector apache#2244 * [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
Purpose of this pull request
Add sentry sink connector
Check list
New License Guide