Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] Add sentry sink connector #2244 #2584

Merged
merged 4 commits into from
Sep 6, 2022
Merged

[Feature][Connector-V2] Add sentry sink connector #2244 #2584

merged 4 commits into from
Sep 6, 2022

Conversation

Saintyang
Copy link
Contributor

@Saintyang Saintyang commented Aug 31, 2022 •
edited
Loading

Purpose of this pull request

Add sentry sink connector

Check list

yangshengjie added 2 commits August 31, 2022 21:41
[Feature][Connector-V2] Add sentry sink connector apache#2244
88df8a8
Merge branch 'dev' into sentry
bfa9c3e 
# Conflicts:
#	plugin-mapping.properties
#	seatunnel-connectors-v2-dist/pom.xml
#	seatunnel-connectors-v2/pom.xml
CalvinKirs
CalvinKirs reviewed Sep 1, 2022
View reviewed changes
seatunnel-connectors-v2/connector-sentry/pom.xml Outdated
<dependency>
<groupId>io.sentry</groupId>
<artifactId>sentry-logback</artifactId>
<version>5.0.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We manage dependencies uniformly in the root pom (dependency managernt)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CalvinKirs
Copy link
Member

Hi, great, could you add some pictures of the corresponding test results? I don't have the corresponding environment

@Saintyang
Copy link
Contributor Author

snapshot
@CalvinKirs maybe you want this? this is the result of running SeaTunnelSentryExample.main()

hailin0
hailin0 reviewed Sep 1, 2022
View reviewed changes
...xamples/seatunnel-flink-connector-v2-example/src/main/resources/examples/fake_to_sentry.conf Outdated
# This is a example source plugin **only for test and demonstrate the feature source plugin**
FakeSource {
result_table_name = "fake"
field_name = "name,age"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merged dev branch? FeakSource updated schema format

#2406

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test all datatypes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i should remove the example code? i didn't see other connector commit the example code

Copy link
Member

@CalvinKirs CalvinKirs Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i should remove the example code?

it's OK to me.
BTW, I'm not sure if it's appropriate for the sink to write directly to SeatunelRow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,i've remove the example class and conf file and pom dependency.

@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 5, 2022

Can you add connector-v2 e2e-testcase & update docs

reference：
e2e: #2499
docs : #2625

@EricJoy2048
Copy link
Member

Can you add connector-v2 e2e-testcase & update docs

reference： e2e: #2499 docs : #2625

I think Sentry Sink can not run e2e.

@Saintyang
Copy link
Contributor Author

Saintyang commented Sep 6, 2022 •
edited
Loading

Can you add connector-v2 e2e-testcase & update docs

reference： e2e: #2499 docs : #2625

Finish updating doc.
As for e2e-test ,I agree with @EricJoy2048 , sentry need user acoount to create config to run the test

@EricJoy2048
Copy link
Member

Document is ok.

@Hisoka-X Hisoka-X merged commit 9fd4039 into apache:dev Sep 6, 2022
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 8, 2022
@Saintyang @MRYOG
[Feature][Connector-V2] Add sentry sink connector apache#2244 (apache…
661ed97 
…#2584)

* [Feature][Connector-V2] Add sentry sink connector apache#2244

* [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class

Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
laglangyue pushed a commit to laglangyue/seatunnel that referenced this pull request Sep 11, 2022
@Saintyang
[Feature][Connector-V2] Add sentry sink connector apache#2244 (apache…
faa165e 
…#2584)

* [Feature][Connector-V2] Add sentry sink connector apache#2244

* [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class

Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
@Hisoka-X Hisoka-X mentioned this pull request Sep 12, 2022
Closed
3 tasks
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 15, 2022
@Saintyang @MRYOG
[Feature][Connector-V2] Add sentry sink connector apache#2244 (apache…
40cf879 
…#2584)

* [Feature][Connector-V2] Add sentry sink connector apache#2244

* [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class

Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
MRYOG pushed a commit to MRYOG/incubator-seatunnel that referenced this pull request Sep 16, 2022
@Saintyang @MRYOG
[Feature][Connector-V2] Add sentry sink connector apache#2244 (apache…
b0a9161 
…#2584)

* [Feature][Connector-V2] Add sentry sink connector apache#2244

* [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class

Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
@Saintyang @TyrantLucifer
[Feature][Connector-V2] Add sentry sink connector apache#2244 (apache…
d77991c 
…#2584)

* [Feature][Connector-V2] Add sentry sink connector apache#2244

* [Feature][Connector-V2] Add sentry sink connector: modify pom.xml and doc, remove example class

Co-authored-by: yangshengjie <yangshengjie@analysys.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@hailin0 hailin0 Awaiting requested review from hailin0

Assignees

@Saintyang Saintyang

Labels
connectors-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Saintyang @CalvinKirs @Hisoka-X @EricJoy2048 @hailin0