Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST-Engine] Use SeatunnelChildFirstClassLoader to loader connector plugin #2479

Merged
merged 35 commits into from
Aug 24, 2022

Conversation

EricJoy2048
Copy link
Member

@EricJoy2048 EricJoy2048 commented Aug 19, 2022

1、Finish a main process, submit-scheduler-finish.
2、Add engine e2e.


transform {
# If you would like to get more information about how to configure seatunnel and see full list of transform plugins,
# please go to https://seatunnel.apache.org/docs/flink/configuration/transform-plugins/Sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https://seatunnel.apache.org/docs/transform/sql ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

# If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
# please go to https://seatunnel.apache.org/docs/flink/configuration/sink-plugins/Console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https://seatunnel.apache.org/docs/connector-v2/sink/LocalFile ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

# If you would like to get more information about how to configure seatunnel and see full list of sink plugins,
# please go to https://seatunnel.apache.org/docs/flink/configuration/sink-plugins/Console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -65,7 +65,7 @@ public SeaTunnelServer(@NonNull Node node, @NonNull SeaTunnelConfig seaTunnelCon
this.liveOperationRegistry = new LiveOperationRegistry();
this.seaTunnelConfig = seaTunnelConfig;
this.executorService =
Executors.newFixedThreadPool(seaTunnelConfig.getEngineConfig().getServerExecutorPoolSize());
Executors.newCachedThreadPool();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define thread name?

explame:

Executors.newCachedThreadPool(new ThreadFactoryBuilder()
                .setNameFormat("seatunnel-server-executor-%d").build());

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -40,7 +40,7 @@ public Address applyForResource(long jobId, long taskId) {
Map<Long, Address> jobAddressMap = physicalVertexIdAndResourceMap.computeIfAbsent(jobId, k -> new HashMap<>());

Address localhost =
jobAddressMap.putIfAbsent(taskId, new Address("localhost", 5701));
jobAddressMap.putIfAbsent(taskId, new Address("192.168.1.10", 5801));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not commit local ip?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

//import java.util.concurrent.atomic.AtomicBoolean;
//import java.util.function.BiConsumer;
//
//public class TaskExecutionServiceTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't commit this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@EricJoy2048 EricJoy2048 changed the title [ST-Engine] Fix logical to physicalplan [ST-Engine] Use SeatunnelChildFirstClassLoader to loader plugin Aug 22, 2022
@EricJoy2048 EricJoy2048 changed the title [ST-Engine] Use SeatunnelChildFirstClassLoader to loader plugin [ST-Engine] Use SeatunnelChildFirstClassLoader to loader connector plugin Aug 22, 2022
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit a845896 into apache:st-engine Aug 24, 2022
# This is a example source plugin **only for test and demonstrate the feature source plugin**
FakeSource {
result_table_name = "fake"
field_name = "name,age",
Copy link
Member

@hailin0 hailin0 Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use new config style? #2406

example:

FakeSource {
    result_table_name = "fake"
    fields {
        name = string
        age = int
    }
}

env {
# You can set flink configuration here
execution.parallelism = 1
job.mode = "STREAMING"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it stop automatically?

Comment on lines +31 to +41
FakeSource {
result_table_name = "fake"
field_name = "name,age",
parallelism = 3
}

FakeSource {
result_table_name = "fake"
field_name = "name,age",
parallelism = 3
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate define?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants