Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use clusters.config.release.list instead of clusters.config.full.list #6583

Merged
merged 1 commit into from
Oct 18, 2023
Merged

use clusters.config.release.list instead of clusters.config.full.list #6583

merged 1 commit into from
Oct 18, 2023

Conversation

thurka
Copy link
Contributor

@thurka thurka commented Oct 18, 2023

This should fix vsix build from release sources.

@thurka thurka self-assigned this Oct 18, 2023
@thurka thurka requested review from lahodaj and MartinBalin October 18, 2023 08:45
@thurka thurka added VSCode Extension [ci] enable VSCode Extension tests LSP [ci] enable Language Server Protocol tests labels Oct 18, 2023
@thurka thurka changed the base branch from master to delivery October 18, 2023 08:46
@neilcsmith-net
Copy link
Member

Thanks @thurka While we wait for tests here, could you confirm that building the VSCode plugin from the source bundle at https://nightlies.apache.org/netbeans/candidate/netbeans/ fails, and that making this change in there fixes it?

@thurka thurka mentioned this pull request Oct 18, 2023
Merged
lahodaj
lahodaj approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@mbien
Copy link
Member

mbien commented Oct 18, 2023

I tried yesterday to reproduce this with github actions so that this can't happen anymore in future (#6579, #6580) but the jobs were green unfortunately.

So if anyone has an idea, contact me and I add it.

@neilcsmith-net
Copy link
Member

neilcsmith-net commented Oct 18, 2023 •
edited
Loading

@mbien you have to run ant build-source-config then use the contents of the resulting zip to build the binaries. First PR doesn't try and build VSCode that way, and second PR just changes clusters.

@thurka
Copy link
Contributor Author

thurka commented Oct 18, 2023

could you confirm

Yes.

neilcsmith-net
neilcsmith-net approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thurka

@neilcsmith-net neilcsmith-net merged commit cc0d88c into apache:delivery Oct 18, 2023
@mbien mbien mentioned this pull request Oct 18, 2023
Merged
@thurka thurka deleted the vsix_build branch October 18, 2023 14:27
@neilcsmith-net neilcsmith-net added this to the NB20 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilcsmith-net neilcsmith-net neilcsmith-net approved these changes

@MartinBalin MartinBalin MartinBalin approved these changes

@lahodaj lahodaj lahodaj approved these changes

@mbien mbien Awaiting requested review from mbien

Assignees

@thurka thurka

Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB20
Development

Successfully merging this pull request may close these issues.
5 participants
@thurka @neilcsmith-net @mbien @MartinBalin @lahodaj