Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NBLS 3rd party licenses #6417

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix NBLS 3rd party licenses #6417

merged 1 commit into from
Sep 7, 2023

Conversation

thurka
Copy link
Contributor

@thurka thurka commented Sep 7, 2023

Top level LICENSE file in apache-netbeans-java-xx.x.xxx.vsix is missing some 3rd party library licenses namely for enterprise, cpplite, extra, groovy and webcommon clusters.

To fix it 'allmodules' should include all clusters not just 'java' and its dependencies, since apache-netbeans-java-xx.x.xxx.vsix contains enterprise, cpplite, extra, groovy and webcommon clusters.

@thurka thurka added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Sep 7, 2023
@thurka thurka self-assigned this Sep 7, 2023
@thurka thurka requested a review from lahodaj September 7, 2023 10:59
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@thurka thurka merged commit 8cfa6e0 into apache:master Sep 7, 2023
@thurka thurka deleted the GCN-3248 branch October 16, 2023 08:55
@neilcsmith-net
Copy link
Member

neilcsmith-net commented Oct 17, 2023

This breaks the release build. Should probably have been cluster.config.release.list or something that picks up the configured cluster config - nb.clusters.list?

There will be no release candidate of the VSCode plugin for 20-rc1, and until this can be fixed on delivery.

cc/ @MartinBalin

@thurka
Copy link
Contributor Author

thurka commented Oct 18, 2023

In the future it would be useful to provide more info about failure. Link to failed build and steps to reproduce. Not everyone if familiar with release process.

@thurka
Copy link
Contributor Author

thurka commented Oct 18, 2023

The PR, which probably can fix the vsix build, is here: #6583

@neilcsmith-net
Copy link
Member

@thurka have added a comment on your PR about testing with the source bundle.

The git repository includes clusters in the full configuration that are not (yet) intended for release. The build server first builds a source bundle of the releasable clusters, then builds binaries from that bundle (which does not include all the clusters in the full configuration).

We're currently discussing on ASF slack how we can test for this.

To replicate the process locally, run ant build-source-config on the repo, then use the resulting zip for a binary build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants