-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add build-from-src-zip job #6579
Conversation
Yes, might not want to do this on every run. We really need to have building the VSCode plugin tied in to the release cluster build here too. Given that's the failure that prompted this. |
yep, had the same thoughts
this might be the missing puzzle piece: CLUSTER_CONFIG: ${{ (contains(github.event.pull_request.labels.*.name, 'rust') || github.event_name != 'pull_request') && 'full' || 'release' }} we are so lucky that fake ternary ops work! We could build the full cluster only when edit: discussed this on slack a bit and we going to leave it on the |
well.. that job was supposed to fail. Lets stash this and try it plan b. |
f4f7e2d
to
ce0e5ec
Compare
ce0e5ec
to
02ba802
Compare
it worked! success! |
Never been happier to see failing tests! 😄 |
6c31df0
to
b3abeeb
Compare
builds platform, release and NB vscode extension from src zips.
b3abeeb
to
a64cc72
Compare
rebased. should be green now if everything goes according to plan edit: tests are green -> merging |
Build from src zip for release and platform in a separate job. This simplifies the platform job too as side effect.
Do we want to do this every time or only when certain labels are set? ( Platform[ci] enable platform tests (platform/*)
,
VSCode Extension
[ci] enable VSCode Extension tests
,
ci:all-tests
[ci] enable all tests
and on master?)
this PR is intended to fail until #6583 made it back to master