Sync delivery to release170 for 17-rc2 #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes three small bugs: - tooltip on unused records will use the right bundle msg - javadoc completion for records - goto impl is now working for records
#5274 overlooked an invisible label which is only visible if an unsupported version is selected in the combo box. This fixes the layout so that making the label visible does not disturb other UI components.
Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Improving indexing for erroneous sources.
UI: fixed conditional gradle version info label.
neilcsmith-net
added
do not merge
- Checks declaration of forbidden methods. - Adds __invoke and __debugInfo to list of magic methods. Docs - https://www.php.net/manual/en/language.enumerations.listing.php - https://www.php.net/manual/en/class.backedenum.php - https://www.php.net/manual/en/language.enumerations.object-differences.php - https://www.php.net/manual/en/language.oop5.magic.php Closes #5086, closes #5094
In PHP method names are case insensitive. Method isMagic() did not work for methods __callStatic, __toString and __debugInfo. Method isConstructor() should compare whole string even though this is already guarded by isMagic().
Fixed detection of magic methods
Improved method checks in enum declaration
added missing record enums to editor module.
PreconditionsChecker: fixed NPE when path is null.
neilcsmith-net
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.