Improved method checks in enum declaration #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi: if you want to get bug fixes into NB17 there is still a chance during the RC phase. All you have to do is to rebase on |
junichi11
reviewed
Jan 22, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/IncorrectEnumHintError.java
Outdated
Show resolved
Hide resolved
|
We should add the following URLs and issue numbers to the commit message.
|
KacerCZ
force-pushed
the
php-enum-check-methods
branch
from
7312ff5 to
a45983c
Compare
|
Thanks for the review. |
|
As @mbien wrote, I think we can change the target to NB17. |
junichi11
approved these changes
Jan 23, 2023
|
@KacerCZ OK, please make sure this is based on top of delivery and update the PR base branch and milestone if you want this to go in to NB17. Will keep an eye out for it. |
KacerCZ
force-pushed
the
php-enum-check-methods
branch
3 times, most recently
from
b061e11 to
a45983c
Compare
- Checks declaration of forbidden methods. - Adds __invoke and __debugInfo to list of magic methods. Docs - https://www.php.net/manual/en/language.enumerations.listing.php - https://www.php.net/manual/en/class.backedenum.php - https://www.php.net/manual/en/language.enumerations.object-differences.php - https://www.php.net/manual/en/language.oop5.magic.php Closes apache#5086, closes apache#5094
KacerCZ
force-pushed
the
php-enum-check-methods
branch
from
a45983c to
6b9c7a3
Compare
|
@junichi11 OK, I didn't wanted to pressure you with the review by targeting NB17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs:
Closes #5086, closes #5094