Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes #5298

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

DevCharly
Copy link
Member

Update FlatLaf to v3.0.

Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/3.0

macOS themes

FlatLaf 3 comes with two new themes, which look similar to macOS:

macOS themes

I've added both to the list of look and feels (on all platforms, screenshots are from Windows 11):

grafik

grafik

Rounded outlined icons

FlatLaf 3 has new modern rounded outlined icons for JFileChooser, JOptionPane, JPasswordField and JTree:

image

They are e.g. used in project/file trees and in file choosers (in all FlatLaf themes):

grafik

@DevCharly DevCharly added Upgrade Library Library (Dependency) Upgrade Look and Feel ci:all-tests [ci] enable all tests labels Jan 16, 2023
@DevCharly DevCharly added this to the NB17 milestone Jan 16, 2023
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new icons.

The dark mac theme might be interesting for those who prefer higher contrast themes.

@DevCharly
Copy link
Member Author

I like the new icons.

Thx 😄

The dark mac theme might be interesting for those who prefer higher contrast themes.

Yes, definitely. That's why I've not limited those themes to mac platform 😉

@mbien
Copy link
Member

mbien commented Jan 16, 2023

@DevCharly its off topic but since I see it in the screenshots. I feel like I am missing out on those nice shortcut buttons on the left side of the file chooser dialog as linux user :)

@neilcsmith-net neilcsmith-net modified the milestones: NB17, NB18 Jan 18, 2023
@neilcsmith-net
Copy link
Member

neilcsmith-net commented Jan 18, 2023

Looks great! I was somewhat tempted to squeeze it in just before I branched, although hadn't had a chance to look properly so didn't want to make the call. If this includes some useful bug fixes, feel free to move to delivery and make the argument for 17-rc2 😄

One concern would be whether we should be using the name macOS in the UI here? Maybe something like FlatLaf Cupertino Light?

Are the mentioned fonts included in this change for NetBeans?

@mbien
Copy link
Member

mbien commented Jan 18, 2023

One concern would be whether we should be using the name macOS in the UI here? Maybe something like FlatLaf Cupertino Light?

agreed. Mac OS is also changing the theme periodically, so it would be better the not associate a Look and Feel with a OS theme to have more flexibility if it needs adjustments. I like Cupertino since it still alludes to the origin.

@neilcsmith-net
Copy link
Member

@mbien to be clear, my main concern is that it's an Apple trademark. While we reference it elsewhere, it's always a direct reference to Apple products, rather than something designed to look similar, as far as I can see.

@mbien
Copy link
Member

mbien commented Jan 18, 2023

@neilcsmith-net yes mine too. I already looked up bug species which like apples but they all have fairly complicated names :)

I only wanted to bring up a technical reason why naming it after an OS might not be a good idea. If it would start diverging from the mac look it might be perceived as a bug.

@DevCharly
Copy link
Member Author

@DevCharly its off topic but since I see it in the screenshots. I feel like I am missing out on those nice shortcut buttons on the left side of the file chooser dialog as linux user :)

Yes, unfortunately the shortcuts are only available on Windows because the used Java API provides the information only on Windows 😞

@DevCharly
Copy link
Member Author

One concern would be whether we should be using the name macOS in the UI here? Maybe something like FlatLaf Cupertino Light?

Good idea 👍
I'm fine with Cupertino

Are the mentioned fonts included in this change for NetBeans?

No. They are in extra JARs.

Copy link
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great--applause!

(Also second the "Cupertino" name, for the trademark reasons and since it's a useful theme even on Windows.)

@eirikbakke
Copy link
Contributor

I tested this patch in its current form on my private NetBeans build; works as expected with no problems.

@mbien
Copy link
Member

mbien commented Jan 21, 2023

if the Cupertino renaming makes it in time before RC2 we should rebase this PR on delivery and get this in for NB 17 in my opinion.

This is technically a bugfix since it removes 8 superfluous pixels on the file open dialog I totally noticed while working with NB 16 :)

@DevCharly
Copy link
Member Author

I've renamed the new themes to Cupertino.

Please let me know if there is a need to rebase this PR to delivery.

But since the branch for this PR was created before the delivery branch was created, there is actually no need to rebase it.
It can be merged directly into the delivery branch. Rebasing makes no difference...

@mbien mbien changed the base branch from master to delivery January 22, 2023 23:41
@mbien mbien modified the milestones: NB18, NB17 Jan 22, 2023
@neilcsmith-net neilcsmith-net merged commit d701a20 into apache:delivery Jan 23, 2023
@DevCharly DevCharly deleted the flatlaf-3.0 branch January 23, 2023 16:47
@Chris2011
Copy link
Contributor

Great icons, but is it possible, that I can change it via the flatlaf properties file? I don't like this mixed stuff what we have. Most of the NetBeans Icons are not outlined and now it looks a bit odd with those all not outlined Icons in the Project window with the just folder outlined ones. As long as we can't switch all icons to either outline or not, I would like to change them by my own. Is this easy possible?

@DevCharly
Copy link
Member Author

@Chris2011 yes, this really looks odd.

Have created PR #5760 to replace FlatLaf outlined folder icons with NetBeans style icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests Look and Feel Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants