-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes #5298
Conversation
e915c72
to
361fb56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new icons.
The dark mac theme might be interesting for those who prefer higher contrast themes.
Thx 😄
Yes, definitely. That's why I've not limited those themes to mac platform 😉 |
@DevCharly its off topic but since I see it in the screenshots. I feel like I am missing out on those nice shortcut buttons on the left side of the file chooser dialog as linux user :) |
Looks great! I was somewhat tempted to squeeze it in just before I branched, although hadn't had a chance to look properly so didn't want to make the call. If this includes some useful bug fixes, feel free to move to delivery and make the argument for 17-rc2 😄 One concern would be whether we should be using the name Are the mentioned fonts included in this change for NetBeans? |
agreed. Mac OS is also changing the theme periodically, so it would be better the not associate a Look and Feel with a OS theme to have more flexibility if it needs adjustments. I like Cupertino since it still alludes to the origin. |
@mbien to be clear, my main concern is that it's an Apple trademark. While we reference it elsewhere, it's always a direct reference to Apple products, rather than something designed to look similar, as far as I can see. |
@neilcsmith-net yes mine too. I already looked up bug species which like apples but they all have fairly complicated names :) I only wanted to bring up a technical reason why naming it after an OS might not be a good idea. If it would start diverging from the mac look it might be perceived as a bug. |
Yes, unfortunately the shortcuts are only available on Windows because the used Java API provides the information only on Windows 😞 |
Good idea 👍
No. They are in extra JARs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great--applause!
(Also second the "Cupertino" name, for the trademark reasons and since it's a useful theme even on Windows.)
I tested this patch in its current form on my private NetBeans build; works as expected with no problems. |
if the This is technically a bugfix since it removes 8 superfluous pixels on the file open dialog I totally noticed while working with NB 16 :) |
I've renamed the new themes to Cupertino. Please let me know if there is a need to rebase this PR to But since the branch for this PR was created before the |
Great icons, but is it possible, that I can change it via the flatlaf properties file? I don't like this mixed stuff what we have. Most of the NetBeans Icons are not outlined and now it looks a bit odd with those all not outlined Icons in the Project window with the just folder outlined ones. As long as we can't switch all icons to either outline or not, I would like to change them by my own. Is this easy possible? |
@Chris2011 yes, this really looks odd. Have created PR #5760 to replace FlatLaf outlined folder icons with NetBeans style icons. |
Update FlatLaf to v3.0.
Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/3.0
macOS themes
FlatLaf 3 comes with two new themes, which look similar to macOS:
I've added both to the list of look and feels (on all platforms, screenshots are from Windows 11):
Rounded outlined icons
FlatLaf 3 has new modern rounded outlined icons for
JFileChooser
,JOptionPane
,JPasswordField
andJTree
:They are e.g. used in project/file trees and in file choosers (in all FlatLaf themes):