KAFKA-18601: Assume a baseline of 3.3 for server protocol versions #18845

ijuma · 2025-02-09T17:04:54Z

3.3.0 was the first KRaft release that was deemed production-ready and also when KIP-778 (KRaft to KRaft upgrades) landed. Given that, it's reasonable for 4.x to only support upgrades from 3.3.0 or newer.

Noteworthy changes:

AlterPartition no longer includes topic names, which makes it possible to simplify AlterParitionManager logic.
Metadata versions older than IBP_3_3_IV3 have been removed and IBP_3_3_IV3 is now the minimum version.
MINIMUM_BOOTSTRAP_VERSION has been removed.
Removed isLeaderRecoverySupported, isNoOpsRecordSupported, isKRaftSupported, isBrokerRegistrationChangeRecordSupported and isInControlledShutdownStateSupported - these are always true now. Also removed related conditional code.
A number of tests were not useful anymore and have been removed.
...

TODO:

Fix failing tests
Update upgrade notes
Explain the changes in more detail

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

Copilot reviewed 61 out of 78 changed files in this pull request and generated no comments.

Files not reviewed (17)

clients/src/main/resources/common/message/AlterPartitionRequest.json: Language not supported
clients/src/main/resources/common/message/AlterPartitionResponse.json: Language not supported
core/src/main/scala/kafka/cluster/Partition.scala: Language not supported
core/src/main/scala/kafka/server/AlterPartitionManager.scala: Language not supported
core/src/main/scala/kafka/server/ControllerRegistrationManager.scala: Language not supported
core/src/main/scala/kafka/server/KafkaConfig.scala: Language not supported
core/src/main/scala/kafka/tools/StorageTool.scala: Language not supported
core/src/main/scala/kafka/tools/TestRaftServer.scala: Language not supported
core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala: Language not supported
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: Language not supported
core/src/test/scala/integration/kafka/server/MetadataVersionIntegrationTest.scala: Language not supported
core/src/test/scala/kafka/server/RemoteLeaderEndPointTest.scala: Language not supported
core/src/test/scala/unit/kafka/cluster/PartitionLockTest.scala: Language not supported
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala: Language not supported
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala: Language not supported
core/src/test/scala/unit/kafka/server/AlterPartitionManagerTest.scala: Language not supported
core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: Language not supported

Comments suppressed due to low confidence (3)

clients/src/test/java/org/apache/kafka/common/requests/AlterPartitionRequestTest.java:46

The removal of the topicName field might lead to incomplete test coverage if any tests rely on it. Verify if topicName is essential for any test cases.

TopicData topicData = new TopicData().setTopicId(topicId);

clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:1705

The removal of the 'topicName' field may cause unintended side effects if the 'topicName' is required elsewhere in the codebase. Please verify if 'topicName' is needed.

.setTopicId(Uuid.randomUuid())

clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:1723

The removal of the 'topicName' field may cause unintended side effects if the 'topicName' is required elsewhere in the codebase. Please verify if 'topicName' is needed.

.setTopicId(Uuid.randomUuid())

tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java

core/src/main/scala/kafka/cluster/Partition.scala

ijuma · 2025-02-10T06:01:54Z

metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java

@@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) {
        for (String name : names) {
            printer.enterNode(name);
            MetadataNode child = child(name);
-            child.print(printer);
+            if (child != null)
+                child.print(printer);


Fixes a NPE I noticed while debugging a failing test.

In reading the code of child, I notice that it seems the AclsImageByIdNode is misplaced.

private static final Map<String, Function<MetadataImage, MetadataNode>> CHILDREN = Map.of( ... // AclsImageByIdNode should be replaced by AclsImageNode AclsImageNode.NAME, image -> new AclsImageByIdNode(image.acls()), ScramImageNode.NAME, image -> new ScramImageNode(image.scram()), DelegationTokenImageNode.NAME, image -> new DelegationTokenImageNode(image.delegationTokens()) );

kafka/metadata/src/main/java/org/apache/kafka/image/node/MetadataImageNode.java

Line 46 in 48283ad

AclsImageNode.NAME, image -> new AclsImageByIdNode(image.acls()),

and AclsImage#toString has similar issue.

@Override public String toString() { // AclsImageByIdNode should be replaced by AclsImageNode return new AclsImageByIdNode(this).stringify(); }

https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/image/AclsImage.java#L78

@ijuma @mumrah WDYT?

Interesting. Shall we file a separate JIRA ticket for that? Perhaps we can wait for @mumrah to confirm.

Hm, it's definitely a bug, but I don't think it relates to this PR. The *Node classes are used by the metadata shell and some toString methods, so they are just informational. I think the exact side effect is that acls would appear at the wrong level of the metadata shell "tree".

I suggest we file a separate issue and fix it for 4.0.

@ijuma @mumrah thanks for your response. open https://issues.apache.org/jira/browse/KAFKA-18803 for it

metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java

ijuma · 2025-02-10T06:04:27Z

metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java

-     * Test downgrading to a MetadataVersion that doesn't support FeatureLevelRecord.
-     */
-    @Test
-    public void testPremodernVersion() {


We don't support these anymore, so remove it.

ijuma · 2025-02-10T06:04:48Z

metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java

-     * Test downgrading to a MetadataVersion that doesn't support inControlledShutdown.
-     */
-    @Test
-    public void testPreControlledShutdownStateVersion() {


We now always have the controlled shutdown state.

ijuma · 2025-02-10T21:02:12Z

server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java

-    }
-
-    @Test
-    public void testKRaftVersions() {


This did not seem to add much value after the changes in this PR.

chia7712

@ijuma thanks for this patch. overall LGTM. some minor comments remains.

metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java

metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadataTest.java

metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java

tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java

metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java

metadata/src/main/java/org/apache/kafka/controller/QuorumController.java

metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java

…ssume-baseline-3.3-for-server * apache-github/trunk: KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion (apache#18820) KAFKA-18658 add import control for examples module (apache#18812) MINOR: Java version and TLS documentation improvements (apache#18822) KAFKA-18743 Remove leader.imbalance.per.broker.percentage as it is not supported by Kraft (apache#18821) KAFKA-18225 ClientQuotaCallback#updateClusterMetadata is unsupported by kraft (apache#18196) KAFKA-18441: Remove flaky tag on KafkaAdminClientTest#testAdminClientApisAuthenticationFailure (apache#18847) MINOR: fix KStream#to incorrect javadoc (apache#18838) KAFKA-18763: changed the assertion statement for acknowledgements to include only successful acks (apache#18846) MINOR: Accept specifying consumer group assignors by their short names (apache#18832)

ijuma · 2025-02-11T05:30:44Z

@junrao Thanks for the review. I addressed your comments and/or replied within the relevant thread. I also pushed a couple of commits for changes I had in progress: (1) Use MINIMUM_VERSION in more places (to reduce future changes) and (2) Set topic id more consistently in PartitionTest. Finally, I also merged from trunk hoping it fixes some of the test failures.

Let's see how the test results look after this.

m1a2st

Thanks @ijuma for this PR, left some commments

server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java

tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java

server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java

ijuma · 2025-02-11T15:56:25Z

Besides the open discussion threads, there are two additional issues to consider/resolve:

Some tests in PlaintextAdminIntegrationTestare failing in the CI runs, but not locally. Unclear why that's the case.
FeaturesDelta.replay reads feature levels from the log and converts them to MetadataVersion. It's possible (but unlikely) that someone ended up with 3.3-IV0, 3.3-IV1, 3.3-IV2 in the log if using an unreleased version of Apache Kafka 3.3. We should consider automatically converting to 3.3-IV3 in such cases.

The failures have the following error:

org.apache.kafka.server.fault.FaultHandlerException: quorumTestHarnessFaultHandler: Broker configuration does not support the cluster MetadataVersion: requirement failed: Multiple log directories (aka JBOD) are not supported in the current MetadataVersion 3.3-IV3. Need 3.7-IV2 or higher

Even though there is a log message just before saying:

Formatting metadata directory /tmp/kafka-2205696658360646817 with metadata.version 4.0-IV3.

junrao

@ijuma : Thanks for the updated PR. Made a pass of all files. A few more comments.

junrao · 2025-02-11T18:40:52Z

metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java

-                singletonMap(MetadataVersion.FEATURE_NAME, MetadataVersion.IBP_3_2_IV0.featureLevel()),
-                singletonMap(MetadataVersion.FEATURE_NAME, FeatureUpdate.UpgradeType.UNSAFE_DOWNGRADE),
-                true));
+            setFeatureLevel(MetadataVersion.IBP_3_4_IV0.featureLevel()));


Should we use MetadataVersion.MINIMUM_VERSION?

This was previously checking that the metadata version would change and using minimum would take it backwards. But I did notice an issue where we are actually using the same version versus a newer one - fixing that.

metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java

junrao · 2025-02-11T19:02:44Z

metadata/src/test/java/org/apache/kafka/image/FeaturesImageTest.java

@@ -163,7 +163,7 @@ public void testEmpty() {
        assertFalse(new FeaturesImage(Collections.singletonMap("foo", (short) 1),
            FeaturesImage.EMPTY.metadataVersion()).isEmpty());
        assertFalse(new FeaturesImage(FeaturesImage.EMPTY.finalizedVersions(),
-            MetadataVersion.IBP_3_3_IV0).isEmpty());
+            MetadataVersion.IBP_3_4_IV0).isEmpty());


Since this can be any MV, could we just use MetadataVersion.MINIMUM_VERSION?

That causes the test to fail. This is related to your question of whether FeatuesImage.isEmpty should be changed not to include metadataVersion.equals(MetadataVersion.MINIMUM_VERSION).

metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java

metadata/src/test/java/org/apache/kafka/image/MetadataVersionChangeTest.java

server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java

junrao

Also, there are a few references to 3.0 in docs/ops.html that need to be changed.

Feature: metadata.version SupportedMinVersion: 3.0-IV1 SupportedMaxVersion: 3.9-IV0 FinalizedVersionLevel: 3.9-IV0 Epoch: 5

m1a2st

Thanks for @ijuma update, left some comments

metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java

core/src/main/scala/kafka/server/AlterPartitionManager.scala

core/src/test/scala/unit/kafka/server/AlterPartitionManagerTest.scala

core/src/test/scala/unit/kafka/server/ApiVersionsResponseIntegrationTest.scala

metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java

…the log to try and debug CI-only test failures

… a specific range)

ijuma · 2025-02-12T15:21:48Z

metadata/src/main/java/org/apache/kafka/image/FeaturesDelta.java

+            // We automatically fallback to IBP_3_3_IV3 in that case. We use explicit versions instead of `MINIMUM_VERSION` because
+            // we want to force an explicit decision if we change `MetadataVersion.MINIMUM_VERSION` in the future.
+            if (record.featureLevel() >= MINIMUM_PERSISTED_FEATURE_LEVEL && record.featureLevel() <= MetadataVersion.IBP_3_3_IV3.featureLevel())
+                metadataVersionChange = MetadataVersion.IBP_3_3_IV3;


@junrao @cmccabe Thoughts on this fallback? It seems like quite a rare edge case (since it requires usage of a pre-release version and for the older metadata version not to be compacted away if I understand correctly), but it seems fair to never fail while reading the log and the fallback code is pretty simple.

Since we only support upgrading from officially released 3.3 to 4.0, we could probably just fail MV 3_3_IV0 to 3_3_IV2 as other unsupported MVs.

Is it guaranteed that we won't have a record with the older metadata version in the log in that case?

There is no guarantee, but the expected MV is IBP_3_3_IV3 and above. If this is not the case, it seems easier to just fail instead of changing it silently.

junrao

@ijuma : Thanks for the updated PR. A few more comments.

junrao · 2025-02-12T17:51:25Z

metadata/src/test/java/org/apache/kafka/image/MetadataVersionChangeTest.java


-    private static final MetadataVersionChange CHANGE_3_3_IV0_TO_3_0_IV1 =
-        new MetadataVersionChange(IBP_3_3_IV0, IBP_3_0_IV1);
+    private static final MetadataVersionChange CHANGE_3_6_IV0_TO_3_3_IV3 =


Could we change this to use MetadataVersion.MINIMUM_VERSION and MetadataVersion.latestProduction() too?

junrao · 2025-02-12T18:30:24Z

metadata/src/main/java/org/apache/kafka/image/FeaturesDelta.java

+            // We automatically fallback to IBP_3_3_IV3 in that case. We use explicit versions instead of `MINIMUM_VERSION` because
+            // we want to force an explicit decision if we change `MetadataVersion.MINIMUM_VERSION` in the future.
+            if (record.featureLevel() >= MINIMUM_PERSISTED_FEATURE_LEVEL && record.featureLevel() <= MetadataVersion.IBP_3_3_IV3.featureLevel())
+                metadataVersionChange = MetadataVersion.IBP_3_3_IV3;


Since we only support upgrading from officially released 3.3 to 4.0, we could probably just fail MV 3_3_IV0 to 3_3_IV2 as other unsupported MVs.

junrao · 2025-02-12T19:53:03Z

metadata/src/main/java/org/apache/kafka/controller/QuorumController.java

-                }
-                return ControllerResult.of(records, false);
-            },
+            () -> ControllerResult.of(List.of(new ApiMessageAndVersion(new NoOpRecord(), (short) 0)), false),


The javadoc above on if the MetadataVersion supports it. needs to be changed too.

server-common/src/main/java/org/apache/kafka/server/common/UnitTestFeatureVersion.java

junrao · 2025-02-12T20:20:25Z

metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java

@@ -56,7 +53,7 @@ public FeaturesImage(

    public boolean isEmpty() {
        return finalizedVersions.isEmpty() &&
-            metadataVersion.equals(MetadataVersion.MINIMUM_KRAFT_VERSION);
+            metadataVersion.equals(MetadataVersion.MINIMUM_VERSION);


isEmpty() is only used in MetadataLoaderTest. So, we can address this in a followup jira. But I am not sure if isEmpty() will ever be false given that metadata version is required in the metadata log and probably the snapshot.

m1a2st

Thanks for @ijuma update, one more comment

metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java

…on whether image is empty

…ssume-baseline-3.3-for-server * apache-github/trunk: (36 commits) MINOR: Add KIP-848's metric to the doc (apache#18890) KAFKA-18772 Define share group config defaults for Docker (apache#18899) KAFKA-18733: Updating share group metrics (1/N) (apache#18826) KAFKA-18634: Fix ELR metadata version issues (apache#18680) KAFKA-18298 Fix flaky testConsumerGroupsDeprecatedConsumerGroupState and testConsumerGroups in PlaintextAdminIntegrationTest (apache#18513) MINOR: Marking testVerifyFetchAndCloseImplicit flaky (apache#18893) MINOR: Adjust javadoc to reflect the correct status of standby task TopicPartition (apache#18892) KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer (apache#18795) KAFKA-16720: Support multiple groups in DescribeShareGroupOffsets RPC (apache#18834) KAFKA-18654[2/2]: Transction V2 retry add partitions on the server side when handling produce request. (apache#18810) MINOR: fix warn log message in Kafka Streams (apache#18878) KAFKA-18776: Fix flaky coordinator disconnect test & fix log level (apache#18866) KAFKA-17298: Update upgrade notes for 4.0 KIP-848 (apache#18756) MINOR bump setup-gradle (apache#18879) MINOR: Run javadoc as part of check task (apache#18863) MINOR: Updated share partition manager tests to close and other fixes (apache#18862) MINOR: Fix typo in ClusterControlManager (apache#18886) KAFKA-18728 Move ListOffsetsPartitionStatus to server module (apache#18807) MINOR: cleanup KStream JavaDocs (14/N) - stream-globalTable-left-join (apache#18867) MINOR: cleanup KStream JavaDocs (13/N) - stream-stream-outer-join (apache#18865) ...

…ssume-baseline-3.3-for-server * apache-github/trunk: MINOR: Add release notes for Transactions Server Side Defense (KIP-890) (apache#18896) MINOR: TransactionManager logs the epoch bump less frequently. (apache#18895) MINOR: Mark IBP_4_0_IV3 as production ready! (apache#18902)

ijuma · 2025-02-14T17:43:28Z

metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java

@@ -100,7 +100,7 @@ public boolean hasSeenRecord() {
     */
    public final void resetToImage(MetadataImage image) {
        this.image = image;
-        this.hasSeenRecord = true;
+        this.hasSeenRecord = !image.isEmpty();


This was an existing issue that somehow became easier to trigger due to these changes. Thanks to @mumrah for figuring out that this was the reason for the remaining failures.

ijuma requested a review from Copilot February 9, 2025 17:04

github-actions bot added core Kafka Broker tools kraft storage Pull requests that target the storage module clients labels Feb 9, 2025

Copilot AI reviewed Feb 9, 2025

View reviewed changes

ijuma commented Feb 9, 2025

View reviewed changes

tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java Show resolved Hide resolved

ijuma force-pushed the kafka-18601-assume-baseline-3.3-for-server branch from 3643409 to a7fbe00 Compare February 10, 2025 03:49

ijuma commented Feb 10, 2025

View reviewed changes

core/src/main/scala/kafka/cluster/Partition.scala Outdated Show resolved Hide resolved

ijuma force-pushed the kafka-18601-assume-baseline-3.3-for-server branch 3 times, most recently from 4b19a3d to 890c3b2 Compare February 10, 2025 05:52

ijuma commented Feb 10, 2025

View reviewed changes

metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java Show resolved Hide resolved

ijuma commented Feb 10, 2025

View reviewed changes

KAFKA-18601: Assume a baseline of 3.3 for server protocol versions

e654cdb

ijuma force-pushed the kafka-18601-assume-baseline-3.3-for-server branch from 890c3b2 to e654cdb Compare February 10, 2025 06:06

ijuma added 2 commits February 10, 2025 07:31

Fix a few tests and tweak error messages

059866e

Minor improvements, address review comments and fix tests

86d1053

ijuma force-pushed the kafka-18601-assume-baseline-3.3-for-server branch from 9622ce9 to 86d1053 Compare February 10, 2025 20:54

Formatting fixes

97e2c43

ijuma commented Feb 10, 2025

View reviewed changes

chia7712 reviewed Feb 10, 2025

View reviewed changes

chia7712 mentioned this pull request Feb 10, 2025

KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion #18820

Merged

3 tasks

ijuma added 2 commits February 10, 2025 15:22

Minor tweak

b60fbe4

github-actions bot added the performance label Feb 11, 2025

Remove ibp parameter from BootstrapDirectory

9fb5b3d

ijuma added 2 commits February 10, 2025 21:27

Replace IBP_3_3_IV3 with MINIMUM_VERSION where applicable

8a81124

Set topicId a bit more consistently in PartitionTest

cdd7c9a

m1a2st reviewed Feb 11, 2025

View reviewed changes

Improve comments and remove code that is no longer needed

942bd2a

junrao reviewed Feb 11, 2025

View reviewed changes

m1a2st reviewed Feb 12, 2025

View reviewed changes

ijuma added 3 commits February 12, 2025 06:43

Address review comments

2f32f35

Don't set metadata version to the MINIMUM_VERSION and rely only on …

b93ba62

…the log to try and debug CI-only test failures

Add fallback in case we read a feature level we don't understand (for…

d8f5346

… a specific range)

ijuma commented Feb 12, 2025

View reviewed changes

ijuma added 3 commits February 12, 2025 11:01

Simplify code based on code review

27e33c4

Remove metadata version default

2d40e5b

More IBP_3_3_IV3 -> MINIMUM_VERSION

32a4a94

junrao reviewed Feb 12, 2025

View reviewed changes

Reject broker registration without metadata.version and fix tests

4b331af

m1a2st reviewed Feb 13, 2025

View reviewed changes

metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java Outdated Show resolved Hide resolved

github-actions bot added the build Gradle build or GitHub Actions label Feb 13, 2025

ijuma force-pushed the kafka-18601-assume-baseline-3.3-for-server branch 2 times, most recently from a5d0b49 to 65a7166 Compare February 13, 2025 16:56

chia7712 mentioned this pull request Feb 14, 2025

KAFKA-18740: Remove BootstrapDirectory#ibp #18905

Open

3 tasks

dajac added the Blocker This pull request is identified as solving a blocker for a release. label Feb 14, 2025

Update MetadataBatchLoader.resetToImage to set hasSeenRecord based …

70667a4

…on whether image is empty

ijuma force-pushed the kafka-18601-assume-baseline-3.3-for-server branch from b6eabaa to 70667a4 Compare February 14, 2025 15:57

ijuma added 2 commits February 14, 2025 08:52

ijuma commented Feb 14, 2025

View reviewed changes

Fix test failures

a551f46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KAFKA-18601: Assume a baseline of 3.3 for server protocol versions #18845

KAFKA-18601: Assume a baseline of 3.3 for server protocol versions #18845

ijuma commented Feb 9, 2025 •

edited

Loading

ijuma Feb 10, 2025

chia7712 Feb 14, 2025

ijuma Feb 14, 2025

mumrah Feb 14, 2025

chia7712 Feb 14, 2025

ijuma Feb 10, 2025 •

edited

Loading

ijuma Feb 10, 2025

ijuma Feb 10, 2025

chia7712 left a comment

ijuma commented Feb 11, 2025

m1a2st left a comment

ijuma commented Feb 11, 2025 •

edited

Loading

junrao left a comment

junrao Feb 11, 2025

ijuma Feb 12, 2025

junrao Feb 11, 2025

ijuma Feb 12, 2025 •

edited

Loading

junrao left a comment

m1a2st left a comment

ijuma Feb 12, 2025

junrao Feb 12, 2025

ijuma Feb 12, 2025

junrao Feb 12, 2025

junrao left a comment

junrao Feb 12, 2025

junrao Feb 12, 2025

junrao Feb 12, 2025

junrao Feb 12, 2025

m1a2st left a comment

ijuma Feb 14, 2025

KAFKA-18601: Assume a baseline of 3.3 for server protocol versions #18845

Are you sure you want to change the base?

KAFKA-18601: Assume a baseline of 3.3 for server protocol versions #18845

Conversation

ijuma commented Feb 9, 2025 • edited Loading

Committer Checklist (excluded from commit message)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ijuma Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chia7712 left a comment

Choose a reason for hiding this comment

ijuma commented Feb 11, 2025

m1a2st left a comment

Choose a reason for hiding this comment

ijuma commented Feb 11, 2025 • edited Loading

junrao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ijuma Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

junrao left a comment

Choose a reason for hiding this comment

m1a2st left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junrao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1a2st left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ijuma commented Feb 9, 2025 •

edited

Loading

ijuma Feb 10, 2025 •

edited

Loading

ijuma commented Feb 11, 2025 •

edited

Loading

ijuma Feb 12, 2025 •

edited

Loading