Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Accept specifying consumer group assignors by their short names #18832

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

dajac
Copy link
Member

@dajac dajac commented Feb 7, 2025

At the moment, we require specifying builtin server side assignors by their full class name. This is not convenient and also exposed their full class name as part of our public API. This patch changes it to accept specifying builtin server side assignor by their short name (uniform or range) while continuing to accept full class name for customer assignors.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 The Next Generation of the Consumer Rebalance Protocol label Feb 7, 2025
Copy link
Contributor

@jeffkbkim jeffkbkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@dajac dajac merged commit be89ce5 into apache:trunk Feb 10, 2025
7 of 9 checks passed
dajac added a commit that referenced this pull request Feb 10, 2025
#18832)

At the moment, we require specifying builtin server side assignors by their full class name. This is not convenient and also exposed their full class name as part of our public API. This patch changes it to accept specifying builtin server side assignor by their short name (uniform or range) while continuing to accept full class name for customer assignors.

Reviewers: Jeff Kim <jeff.kim@confluent.io>
@dajac
Copy link
Member Author

dajac commented Feb 10, 2025

Merged to trunk and 4.0.

ijuma added a commit to ijuma/kafka that referenced this pull request Feb 11, 2025
…ssume-baseline-3.3-for-server

* apache-github/trunk:
  KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion (apache#18820)
  KAFKA-18658 add import control for examples module (apache#18812)
  MINOR: Java version and TLS documentation improvements (apache#18822)
  KAFKA-18743 Remove leader.imbalance.per.broker.percentage as it is not supported by Kraft (apache#18821)
  KAFKA-18225 ClientQuotaCallback#updateClusterMetadata is unsupported by kraft (apache#18196)
  KAFKA-18441: Remove flaky tag on KafkaAdminClientTest#testAdminClientApisAuthenticationFailure (apache#18847)
  MINOR: fix KStream#to incorrect javadoc (apache#18838)
  KAFKA-18763: changed the assertion statement for acknowledgements to include only successful acks (apache#18846)
  MINOR: Accept specifying consumer group assignors by their short names (apache#18832)
pdruley pushed a commit to pdruley/kafka that referenced this pull request Feb 12, 2025
apache#18832)

At the moment, we require specifying builtin server side assignors by their full class name. This is not convenient and also exposed their full class name as part of our public API. This patch changes it to accept specifying builtin server side assignor by their short name (uniform or range) while continuing to accept full class name for customer assignors.

Reviewers: Jeff Kim <jeff.kim@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KIP-848 The Next Generation of the Consumer Rebalance Protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants