KAFKA-18743: leader.imbalance.per.broker.percentage is not supported by Kraft #18821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Feb 6, 2025
docs/zk2kraft.html
Outdated
| @@ -103,6 +103,15 @@ <h5 class="anchor-heading">Removal Zookeeper configs</h5> | |||
| <li><code>advertised.listeners</code></li> | |||
| </ul> | |||
| </li> | |||
| <li> | |||
| <p> | |||
| Removed the leader imbalance configuration used only in ZooKeeper. In KRaft mode, <code>leader.imbalance.per.broker.percentage</code> | |||
There was a problem hiding this comment.
Maybe we can add a bit explanation for it? could you please take a look at the jira that I have written the purpose of this config.
chia7712
reviewed
Feb 6, 2025
chia7712
approved these changes
Feb 7, 2025
|
@Yunyung could you please rebase code to run QA again? |
chia7712
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
LGTM
the failed tests are traced by following jiras
https://issues.apache.org/jira/browse/KAFKA-18105
https://issues.apache.org/jira/browse/KAFKA-16024
https://issues.apache.org/jira/browse/KAFKA-18770
chia7712
pushed a commit
that referenced
this pull request
Feb 10, 2025
…t supported by Kraft (#18821) Remove `leader.imbalance.per.broker.percentage` from config. Add `leader.imbalance.per.broker.percentage` to release note Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Feb 11, 2025
…ssume-baseline-3.3-for-server * apache-github/trunk: KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion (apache#18820) KAFKA-18658 add import control for examples module (apache#18812) MINOR: Java version and TLS documentation improvements (apache#18822) KAFKA-18743 Remove leader.imbalance.per.broker.percentage as it is not supported by Kraft (apache#18821) KAFKA-18225 ClientQuotaCallback#updateClusterMetadata is unsupported by kraft (apache#18196) KAFKA-18441: Remove flaky tag on KafkaAdminClientTest#testAdminClientApisAuthenticationFailure (apache#18847) MINOR: fix KStream#to incorrect javadoc (apache#18838) KAFKA-18763: changed the assertion statement for acknowledgements to include only successful acks (apache#18846) MINOR: Accept specifying consumer group assignors by their short names (apache#18832)
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
…t supported by Kraft (apache#18821) Remove `leader.imbalance.per.broker.percentage` from config. Add `leader.imbalance.per.broker.percentage` to release note Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
leader.imbalance.per.broker.percentageas it is only for ZK.Jira: https://issues.apache.org/jira/browse/KAFKA-18743
Committer Checklist (excluded from commit message)