GH-39965: [C++] DatasetWriter avoid creating zero-sized batch when max_rows_per_file enabled
#39995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mapleFU
commented
Feb 8, 2024
github-actions
bot
added
awaiting committer review
bkietz
requested changes
Feb 13, 2024
github-actions
bot
added
awaiting changes
|
@bkietz comment resolved |
github-actions
bot
added
awaiting change review
kou
approved these changes
Feb 22, 2024
| @@ -198,9 +198,7 @@ class DatasetWriterTestFixture : public testing::Test { | |||
| int num_batches = 0; | |||
| AssertBatchesEqual(*MakeBatch(expected_file.start, expected_file.num_rows), | |||
| *ReadAsBatch(written_file->data, &num_batches)); | |||
| if (check_num_record_batches) { | |||
There was a problem hiding this comment.
Can we remove bool check_num_record_batches = true argument?
There was a problem hiding this comment.
Sure, this is added in my previous patch #38885 . Here if not passing check_num_record_batches = false, the check would failed because zero-sized batch.
In this patch, it would not be produced, so I can remove it
There was a problem hiding this comment.
OK. Please remove it before we merge this.
github-actions
bot
added
awaiting merge
|
Will merge if no negative comment tommorrow. |
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5f75dbf. There were 10 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
…hen `max_rows_per_file` enabled (apache#39995) ### Rationale for this change `DatasetWriter` might create empty `RecordBatch` when `max_rows_per_file` enabled. This is because `NextWritableChunk` might return a zero-sized batch when the file exactly contains the dest data. ### What changes are included in this PR? Check batch-size == 0 when append to file queue ### Are these changes tested? Yes ### Are there any user-facing changes? User can avoid zero-sized row-group/batch. * Closes: apache#39965 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…hen `max_rows_per_file` enabled (apache#39995) ### Rationale for this change `DatasetWriter` might create empty `RecordBatch` when `max_rows_per_file` enabled. This is because `NextWritableChunk` might return a zero-sized batch when the file exactly contains the dest data. ### What changes are included in this PR? Check batch-size == 0 when append to file queue ### Are these changes tested? Yes ### Are there any user-facing changes? User can avoid zero-sized row-group/batch. * Closes: apache#39965 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DatasetWritermight create emptyRecordBatchwhenmax_rows_per_fileenabled. This is becauseNextWritableChunkmight return a zero-sized batch when the file exactly contains the dest data.What changes are included in this PR?
Check batch-size == 0 when append to file queue
Are these changes tested?
Yes
Are there any user-facing changes?
User can avoid zero-sized row-group/batch.
ds.write_dataset#39965