forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
apacheGH-39965: [C++] DatasetWriter avoid creating zero-sized batch w…
…hen `max_rows_per_file` enabled (apache#39995) ### Rationale for this change `DatasetWriter` might create empty `RecordBatch` when `max_rows_per_file` enabled. This is because `NextWritableChunk` might return a zero-sized batch when the file exactly contains the dest data. ### What changes are included in this PR? Check batch-size == 0 when append to file queue ### Are these changes tested? Yes ### Are there any user-facing changes? User can avoid zero-sized row-group/batch. * Closes: apache#39965 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
- Loading branch information
1 parent
499714e
commit e9c6922
Showing
2 changed files
with
30 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters