Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] fix max_rows_per_group must be a positive number #40742

Open
r2evans opened this issue Mar 22, 2024 · 1 comment
Open

[R] fix max_rows_per_group must be a positive number #40742

r2evans opened this issue Mar 22, 2024 · 1 comment

Comments

@r2evans
Copy link

r2evans commented Mar 22, 2024

Describe the bug, including details regarding any error messages, version, and platform.

arrow::write_dataset(dataset = x, path = "...", partitioning = somekeys,
                         max_rows_per_file = 0L)
# Error: Invalid: max_rows_per_group must be a positive number

The document says

max_rows_per_file: maximum number of rows per file. If greater than 0
          then this will limit how many rows are placed in any single
          file. Default is 0L.

min_rows_per_group: write the row groups to the disk when this number
          of rows have accumulated. Default is 0L.

Two things:

  • the error references an argument that was not provided
  • either update the documentation or accept 0 as an acceptable argument (that just reasserts the behavior of "no limit")

Component(s)

R

@thisisnic
Copy link
Member

Thanks for reporting this @r2evans, can confirm I can reproduce this. The error is being propagated from the C++ layer, and I think it might be related to #39995, but need to double-check.

@thisisnic thisisnic changed the title fix max_rows_per_group must be a positive number [R] fix max_rows_per_group must be a positive number Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants