CI: try to run reuse workflow without explicitly allowing it for new contributors #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
approved these changes
Sep 19, 2022
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha || '' }} |
There was a problem hiding this comment.
This looks ok to me. IIRC we found that the merge "branch" is better usually, but it's not available on the opened trigger. I'd guess this will be good enough though. It will likely suffer from similar issues we saw of when a PR branch is behind the target branch, and errors were in the target at the time of branching but since fixed.
I'd say it's worth merging it like this because it's a much easier way of doing it, and if it causes problems, then try to something with the merge branch.
There was a problem hiding this comment.
For this test (run reuse lint) I think the PR's branch suffices, instead of the merge commit. Assuming the reuse tool doesn't suddenly has breaking changes :)
|
@briantist thanks for reviewing this! |
v1v
added a commit
to v1v/community.general
that referenced
this pull request
Oct 7, 2022
* upstream/main: (203 commits) Make pfexec become usable for illumos (ansible-collections#3889) znode: add options for authentication (ansible-collections#5306) keycloak_user_federation: add explanation and example to vendor option (ansible-collections#4893) Next expected release is 5.8.0. Allow terraform module to specify complex variable structures (ansible-collections#4797) Fix ansible-collections#5313: redhat_subscription module is not idempotent when pool_ids (ansible-collections#5319) bitwarden: Add field to search for all item attributes, instead of on… (ansible-collections#5297) New Module: Keycloak User Rolemapping (ansible-collections#4898) chore: Update lxc_container to support py3 (ansible-collections#5304) terraform: run `init` with no-color, too (ansible-collections#5147) nmcli: fix error when setting previously unset mac address (ansible-collections#5291) [feat] proxmox_snap: snapshot containers with configured mountpoints (ansible-collections#5274) machinectl: include the success command (ansible-collections#5287) Add SetSessionService to redfish_config (ansible-collections#5009) locale_gen: fix UbuntuMode (ansible-collections#5282) ini_file: fix lint error (ansible-collections#5307) netcup_dnsapi: Add timeout paramter (ansible-collections#5301) stable-2.14 is now default. Add stable-2.14 to CI, adjust to devel version bump (ansible-collections#5298) Try to run reuse workflow without explicitly allowing it for new contributors. (ansible-collections#5296) ...
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Right now we have to explicitly allow to run that workflow for new contributors. That's annoying and not really necessary.
ISSUE TYPE
COMPONENT NAME
CI