Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: try to run reuse workflow without explicitly allowing it for new contributors #5296

Merged
merged 1 commit into from
Sep 19, 2022
Merged

CI: try to run reuse workflow without explicitly allowing it for new contributors #5296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/reuse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ name: Verify REUSE
on:
push:
branches: [main]
pull_request:
pull_request_target:
types: [opened, synchronize, reopened]
branches: [main]
# Run CI once per day (at 07:30 UTC)
schedule:
Expand All @@ -21,7 +22,9 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha || '' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. IIRC we found that the merge "branch" is better usually, but it's not available on the opened trigger. I'd guess this will be good enough though. It will likely suffer from similar issues we saw of when a PR branch is behind the target branch, and errors were in the target at the time of branching but since fixed.

I'd say it's worth merging it like this because it's a much easier way of doing it, and if it causes problems, then try to something with the merge branch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test (run reuse lint) I think the PR's branch suffices, instead of the merge commit. Assuming the reuse tool doesn't suddenly has breaking changes :)


- name: Install dependencies
run: |
Expand Down