Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcup_dnsapi: Add timeout paramter #5301

Merged
merged 4 commits into from
Sep 22, 2022
Merged

netcup_dnsapi: Add timeout paramter #5301

merged 4 commits into from
Sep 22, 2022

Conversation

marcquark
Copy link
Contributor

SUMMARY

The netcup_dnaspi module relies on python package nc_dnsapi which supports specifying a connection timeout, defaulting to 5 (see https://github.com/nbuchwitz/nc_dnsapi/blob/master/nc_dnsapi/__init__.py#L186)
Being able to specify a value higher than the default is helpful when working on an unstable or high-latency internet connection (e.g. LTE)

This change adds a timeout parameter to the netcup_dnsapi module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netcup_dnsapi

ADDITIONAL INFORMATION

none

@ansibullbot
Copy link
Collaborator

cc @nbuchwitz
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 21, 2022
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Sep 21, 2022
felixfontein
felixfontein reviewed Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

changelogs/fragments/5301-netcup_dnsapi-timeout.yml Outdated Show resolved Hide resolved
plugins/modules/net_tools/netcup_dns.py Show resolved Hide resolved
plugins/modules/net_tools/netcup_dns.py Outdated Show resolved Hide resolved
@marcquark @felixfontein
Apply suggestions from code review
9b85a8b 
Co-authored-by: Felix Fontein <felix@fontein.de>
@marcquark
Copy link
Contributor Author

Hey there,
thx for the lightning fast review and suggestions. Agree with all of 'em

@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Sep 21, 2022
@nbuchwitz
Copy link

nbuchwitz commented Sep 21, 2022 •
edited
Loading

The failed checks complain about the unused newline in changelog fragment.besides that and what @felixfontein suggested LGTM

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Sep 21, 2022
@nbuchwitz
Copy link

shipit

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 22, 2022
@felixfontein felixfontein merged commit a6c8078 into ansible-collections:main Sep 22, 2022
@patchback
Copy link

patchback bot commented Sep 22, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/a6c8078ccf4578fe2a15e2d97eca716ba6fc9a1d/pr-5301

Backported as #5302

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 22, 2022
@marcquark @patchback
netcup_dnsapi: Add timeout paramter (#5301)
c26974b 
* netcup_dnsapi: Add timeout paramter

* add changelog fragment

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* remove unnecessary newline

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit a6c8078)
@patchback patchback bot mentioned this pull request Sep 22, 2022
Merged
@felixfontein
Copy link
Collaborator

@marcquark thanks for your contribution!
@nbuchwitz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Sep 22, 2022
@patchback @marcquark
netcup_dnsapi: Add timeout paramter (#5301) (#5302)
b4ae2ce 
* netcup_dnsapi: Add timeout paramter

* add changelog fragment

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* remove unnecessary newline

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit a6c8078)

Co-authored-by: Marc Leuser <marcquark@users.noreply.github.com>
v1v added a commit to v1v/community.general that referenced this pull request Oct 7, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/support-logs
3d0c09d 
* upstream/main: (203 commits)
  Make pfexec become usable for illumos (ansible-collections#3889)
  znode: add options for authentication (ansible-collections#5306)
  keycloak_user_federation: add explanation and example to vendor option (ansible-collections#4893)
  Next expected release is 5.8.0.
  Allow terraform module to specify complex variable structures (ansible-collections#4797)
  Fix ansible-collections#5313: redhat_subscription module is not idempotent when pool_ids (ansible-collections#5319)
  bitwarden: Add field to search for all item attributes, instead of on… (ansible-collections#5297)
  New Module: Keycloak User Rolemapping (ansible-collections#4898)
  chore: Update lxc_container to support py3 (ansible-collections#5304)
  terraform: run `init` with no-color, too (ansible-collections#5147)
  nmcli: fix error when setting previously unset mac address (ansible-collections#5291)
  [feat] proxmox_snap: snapshot containers with configured mountpoints (ansible-collections#5274)
  machinectl: include the success command (ansible-collections#5287)
  Add SetSessionService to redfish_config (ansible-collections#5009)
  locale_gen: fix UbuntuMode (ansible-collections#5282)
  ini_file: fix lint error (ansible-collections#5307)
  netcup_dnsapi: Add timeout paramter (ansible-collections#5301)
  stable-2.14 is now default.
  Add stable-2.14 to CI, adjust to devel version bump (ansible-collections#5298)
  Try to run reuse workflow without explicitly allowing it for new contributors. (ansible-collections#5296)
  ...
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcquark @ansibullbot @nbuchwitz @felixfontein