Fix returnall for gopass

[TheLastProject]

SUMMARY

Gopass was always given the --password flag, despite there being no need for this. Therefore, it only ever returned the first line, breaking returnall.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

passwordstore

ADDITIONAL INFORMATION

Create a multi-line password in gopass

echo -e "Multi\\nline\\ntest" | gopass insert test

Run the following playbook:

---
- hosts: localhost
  tasks:
    - name: Print only first line
      ansible.builtin.debug:
        msg: "{{ lookup('community.general.passwordstore', 'test', backend='gopass') }}"
    - name: Print all lines
      ansible.builtin.debug:
        msg: "{{ lookup('community.general.passwordstore', 'test returnall=true', backend='gopass') }}"

Before patch:

❯ ansible-playbook playbook.yml 
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

PLAY [localhost] ***************************************************************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] *********************************************************************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [Print only first line] ***************************************************************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "Multi"
}

TASK [Print all lines] *********************************************************************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "Multi"
}

PLAY RECAP *********************************************************************************************************************************************************************************************************************************************************************************
localhost                  : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

After patch:

❯ ansible-playbook playbook.yml 
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

PLAY [localhost] *****************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************
ok: [localhost]

TASK [Print only first line] *****************************************************************************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "Multi"
}

TASK [Print all lines] ***********************************************************************************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "Multi\nline\ntest"
}

PLAY RECAP ***********************************************************************************************************************************
localhost                  : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Note: this is a redo of #5020, which became an overly complex discussion due to other unrelated bugs being found during this bugfix.

[felixfontein]

CC @grembo

[grembo]

@TheLastProject @felixfontein This looks good to me now.

[felixfontein]

Great, then let's merge this :-)

[patchback]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/3eb29eb4b6ba06f67e5ed73e8044d4561ac50b9f/pr-5027

Backported as #5029

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@TheLastProject thanks for fixing this!
@grembo thanks for reviewing!

[felixfontein]

BTW, if someone wants to extend the integration tests to run with real gopass, that would be pretty cool! But don't feel pressured, I have no clue how much work this would be... ;-)

[grembo]

BTW, if someone wants to extend the integration tests to run with real gopass, that would be pretty cool! But don't feel pressured, I have no clue how much work this would be... ;-)

I started this in #5030 (work in progress to get all the various packages right)