Fix returnall for gopass (#5027) (#5029)

* Fix returnall for gopass

Gopass was always given the --password flag, despite there being no need for this.

* Add changelog fragment

Co-authored-by: Sylvia van Os <sylvia.van.os@politie.nl>
(cherry picked from commit 3eb29eb)

Co-authored-by: Sylvia van Os <sylvia@hackerchick.me>

changelogs/fragments/5027-fix-returnall-for-gopass.yaml

@@ -0,0 +1,2 @@
+bugfixes:
+  - passwordstore lookup plugin - fix ``returnall`` for gopass (https://github.com/ansible-collections/community.general/pull/5027).

plugins/lookup/passwordstore.py

@@ -261,11 +261,11 @@ def __init__(self, loader=None, templar=None, **kwargs):
     def is_real_pass(self):
         if self.realpass is None:
             try:
-                self.passoutput = to_text(
+                passoutput = to_text(
                     check_output2([self.pass_cmd, "--version"], env=self.env),
                     errors='surrogate_or_strict'
                 )
-                self.realpass = 'pass: the standard unix password manager' in self.passoutput
+                self.realpass = 'pass: the standard unix password manager' in passoutput
             except (subprocess.CalledProcessError) as e:
                 raise AnsibleError(e)
 
@@ -331,7 +331,6 @@ def check_pass(self):
         try:
             self.passoutput = to_text(
                 check_output2([self.pass_cmd, 'show'] +
-                              (['--password'] if self.backend == 'gopass' else []) +
                               [self.passname], env=self.env),
                 errors='surrogate_or_strict'
             ).splitlines()

tests/integration/targets/lookup_passwordstore/tasks/tests.yml

@@ -318,9 +318,6 @@
         if [ "$1" = "--version" ]; then
           exit 2
         fi
-        if [ "$1" = "show" ] && [ "$2" != "--password" ]; then
-          exit 3
-        fi
         echo "gopass_ok"
       dest: "{{ gopasspath }}"
       mode: '0755'