passwordstore: Add some real gopass integration tests #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is work in progress.
grembo
force-pushed
the
lookup_passwordstore_gopass_tests
branch
from
c04ea80 to
8d15047
Compare
ansibullbot
added
feature
felixfontein
added
check-before-release
grembo
force-pushed
the
lookup_passwordstore_gopass_tests
branch
3 times, most recently
from
5798cf1 to
395c5e0
Compare
Part of integration tests
grembo
force-pushed
the
lookup_passwordstore_gopass_tests
branch
from
395c5e0 to
aed7d1d
Compare
ansibullbot
removed
the
needs_revision
grembo
force-pushed
the
lookup_passwordstore_gopass_tests
branch
from
0087045 to
6e2597d
Compare
|
@felixfontein This is ready to be reviewed now. |
changelogs/fragments/5030-add-gopass-tests-to-lookup-passwordstore-plugin.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/lookup_passwordstore/tasks/package.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/lookup_passwordstore/tasks/package.yml
Outdated
Show resolved
Hide resolved
grembo
force-pushed
the
lookup_passwordstore_gopass_tests
branch
from
7b7bdaf to
fe615ab
Compare
felixfontein
approved these changes
Jul 31, 2022
|
I'll merge this later today if nobody complains :) |
felixfontein
removed
the
check-before-release
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5042 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 31, 2022
* passwordstore: Add some real go tests This is work in progress. * passwordstore: Fix gopass init * Init gopass store in explicit path in integration test * passwordstore: Show versions of tools in integration test * passwordstore: Install gopass from different location on Debian Part of integration tests * passwordstore: Add changelog fragment for #5030 * passwordstore: Address review feedback (cherry picked from commit 74f2e1d)
|
@grembo thanks for contributing these tests! |
@felixfontein Thanks for reviewing them! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
pushed a commit
that referenced
this pull request
Jul 31, 2022
* passwordstore: Add some real go tests This is work in progress. * passwordstore: Fix gopass init * Init gopass store in explicit path in integration test * passwordstore: Show versions of tools in integration test * passwordstore: Install gopass from different location on Debian Part of integration tests * passwordstore: Add changelog fragment for #5030 * passwordstore: Address review feedback (cherry picked from commit 74f2e1d) Co-authored-by: grembo <freebsd@grem.de>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…tions#5030) * passwordstore: Add some real go tests This is work in progress. * passwordstore: Fix gopass init * Init gopass store in explicit path in integration test * passwordstore: Show versions of tools in integration test * passwordstore: Install gopass from different location on Debian Part of integration tests * passwordstore: Add changelog fragment for ansible-collections#5030 * passwordstore: Address review feedback
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…tions#5030) * passwordstore: Add some real go tests This is work in progress. * passwordstore: Fix gopass init * Init gopass store in explicit path in integration test * passwordstore: Show versions of tools in integration test * passwordstore: Install gopass from different location on Debian Part of integration tests * passwordstore: Add changelog fragment for ansible-collections#5030 * passwordstore: Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since the lookup_passwordstore module gained some real gopass support, add real unit tests for it.
ISSUE TYPE
COMPONENT NAME
lookup_passwordstore