#13282: Fixes Android Studio Warnings under Kotlin Header #15704

awanishyadav967 · 2024-02-28T14:40:46Z

Description

I addressed the issue #13282 by fixing Android Studio warnings under Kotlin ->redundant constructs header (The list of warnings can be obtained via: Code -> Inspect Code). The changes include removing redundant constructs such as unused imports and redundant quantifier names.

Fixes

Fixes [Cleanup]: Fix Android Studio Warnings #13282

Approach

I reviewed the code and identified areas with Android Studio warnings. I removed unnecessary constructs to improve code readability and maintainability.

How Has This Been Tested?

I tested these changes on Level 30 (Android 11).

Before

After

Checklist

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

welcome · 2024-02-28T14:40:49Z

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

david-allison

Thanks!

AnkiDroid/src/main/java/com/ichi2/libanki/backend/model/NoteUtil.kt

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckSelectionDialog.kt

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

david-allison · 2024-02-28T14:46:12Z

api/src/main/java/com/ichi2/anki/FlashCardsContract.kt

-public object FlashCardsContract {
-    public const val AUTHORITY: String = BuildConfig.AUTHORITY
-    public const val READ_WRITE_PERMISSION: String = BuildConfig.READ_WRITE_PERMISSION
+object FlashCardsContract {


all our API files should require public due to explicitApi

david-allison · 2024-02-28T18:29:13Z

api/src/main/java/com/ichi2/anki/FlashCardsContract.kt

-object FlashCardsContract {
-    const val AUTHORITY: String = BuildConfig.AUTHORITY
-    const val READ_WRITE_PERMISSION: String = BuildConfig.READ_WRITE_PERMISSION
+public object FlashCardsContract {


Thanks!

all the files in api should be reverted

awanishyadav967 · 2024-02-28T18:37:19Z

Thanks!

Thank you for your feedback and suggestions. I've made the necessary changes as requested. Please take another look when you have a chance.

david-allison

Thanks! Last one I think

david-allison · 2024-02-28T18:38:40Z

AnkiDroid/src/main/java/com/ichi2/anki/AnkiActivity.kt

@@ -339,7 +346,7 @@ open class AnkiActivity : AppCompatActivity, SimpleMessageDialogListener {
            .setToolbarColor(toolbarColor)
            .setNavigationBarColor(navBarColor)
            .build()
-        val builder = CustomTabsIntent.Builder(customTabActivityHelper.session)
+        val builder = Builder(customTabActivityHelper.session)


This shouldn't be imported as we lose context for the containing type

Would you recommend reverting the change or is there a preferred approach for handling this? @david-allison

revert the change, remove the import if possible

david-allison · 2024-02-28T18:39:52Z

api/src/main/java/com/ichi2/anki/FlashCardsContract.kt

@@ -189,7 +189,7 @@ public object FlashCardsContract {
     * --------------------------------------------------------------------------------------------------------------------
     * ```
     */
-    public object Note {
+    object Note {


changes to this class need reverting

david-allison · 2024-02-28T18:40:11Z

api/src/main/java/com/ichi2/anki/api/NoteInfo.kt

@@ -24,7 +24,7 @@ import java.util.*
 * Representation of the contents of a note in AnkiDroid.
 */
 @Suppress("unused")
-public class NoteInfo {
+class NoteInfo {


changes to this class need reverting

neeldoshii · 2024-02-29T03:30:32Z

Code Quality failing.

try running
./gradlew ktlintFormat to fix the code qualty test.

awanishyadav967 · 2024-02-29T08:25:00Z

Code Quality failing.

try running ./gradlew ktlintFormat to fix the code qualty test.

Hi @neeldoshii thanks ,I think this happen because I commit (try to solve merge conflict in one of the import) directly from the github , Right now i am travelling ,there is few review(comments) i have to revert ,I will soon make a new PR 👍

david-allison · 2024-02-29T08:34:16Z

Hi @awanishyadav967, we prefer rebase + force-push rather than making new PRs, we want to keep the code review history in one place

No rush, and enjoy your travels!

awanishyadav967 · 2024-02-29T08:46:30Z

Hi @awanishyadav967, we prefer rebase + force-push rather than making new PRs, we want to keep the code review history in one place

No rush, and enjoy your travels!

Thanks, @david-allison, for the input! I'll use rebase + force-push to maintain the code review history in one place. Appreciate the guidance, and I'll take care of it.

neeldoshii · 2024-02-29T13:55:07Z

Test cases failing.

Visibility must be specified in explicit API mode

david-allison · 2024-02-29T14:02:11Z

Just to note: you can reproduce the local failures by rebasing onto main

Update api build.gradle to enable explicitApi() #15709 has just come in, which means CI and your IDE requires public for all methods/properties in the API

the fields need to be passed for the card to be previewed, but they weren't built in IO so they couldn't have their values taken

* Keep the widgets disabled until the application has storage access

If a screen is backgrounded, `requireActivity()` throws `IllegalStateException("Fragment " + this + " not attached to an activity.")` The request which caused this was `/_anki/congratsInfo` which occurred every minute This was returned to the screen and caused a messagebox to appear And one messagebox per minute eventually exceeded the system window limit Causing issue 15659: a crash with "window count is over max!!" To fix this, allow a null activity Fixes 15679

The current implementation using messages and handlers for async dialogs means that if the user tries to import before actually starting the app the import dialog ends up being shown in the introduction screen ending up in a crash. These changes prevent that by checking for this scenario and notifying the user that he must start the app at least once before any import can be done. The hasShownAppIntro() was moved to better structure the code(it's related to the introduction screen) and for ease of access in the screens that use it.

see 15707

* Fix : Multiple instance of dialog shown * Simplified the layout, increased padding and touch target * Increased the top and bottom padding * Fix : My search uses divider and fixed padding

…t file" This reverts commit f5d1017.

awanishyadav967 · 2024-02-29T20:01:35Z

Test cases failing.

Visibility must be specified in explicit API mode

Hi @neeldoshii ,The local test cases passed, but they're failing in CI. Any suggestions or insights into possible reasons for the this?

neeldoshii · 2024-03-02T12:56:11Z

Hi @neeldoshii ,The local test cases passed, but they're failing in CI. Any suggestions or insights into possible reasons for the this?

Hi @awanishyadav967, you haven't done rebase properly see

Coming to your point, #15709 we have added an explictAPi() method which make sure's all the API calls are set to public.
Check Comment By @david-allison

Also you have conflicts in your PR now so you need to fix the conflicts too 😔.

neeldoshii · 2024-03-08T12:33:16Z

Hi @awanishyadav967, I noticed you closed the PR do you need any help?

awanishyadav967 · 2024-03-08T12:45:16Z

Hi @awanishyadav967, I noticed you closed the PR do you need any help?

Hi @neeldoshii I think I created a mess here, I just want to create new pr ,I tried rebasing and reverting my changes but it does worked for me .

awanishyadav967 · 2024-03-08T17:01:23Z

Hi @david-allison @neeldoshii,
Just wanted to give you a heads up – I've set up a new PR and linked it here. Take a look whenever you get a chance, and let me know if any changes are needed. Appreciate your time!

#13282: Fixes Android Studio Warnings under Kotlin Header

9ca8096

github-actions bot added the New contributor label Feb 28, 2024

david-allison reviewed Feb 28, 2024

View reviewed changes

david-allison mentioned this pull request Feb 28, 2024

API needs explicitApi #15705

Closed

david-allison added the Needs Author Reply Waiting for a reply from the original author label Feb 28, 2024

Address reviewer comments

b463397

david-allison reviewed Feb 28, 2024

View reviewed changes

awanishyadav967 requested a review from david-allison February 28, 2024 18:37

david-allison requested changes Feb 28, 2024

View reviewed changes

david-allison added squash-merge The pull request currently requires maintainers to "Squash Merge" and removed Needs Author Reply Waiting for a reply from the original author labels Feb 28, 2024

lukstbit added the Needs Author Reply Waiting for a reply from the original author label Feb 29, 2024

BrayanDSO and others added 10 commits February 29, 2024 22:42

fix: image occlusion cards couldn't be previewed in the note editor

b05e140

the fields need to be passed for the card to be previewed, but they weren't built in IO so they couldn't have their values taken

fix: Don't enable the shortcuts unless file access is given

4555db2

* Keep the widgets disabled until the application has storage access

Updated strings from Crowdin

8b223da

chore(logs): log buildResponse failure

4c23353

feat: add summary and help icon to User actions

714c271

Enhance explicit API compliance, revert specific files

a7cf8be

test: ignore NoteEditorIntentTest in CI

cb5b5a4

see 15707

Updated strings from Crowdin

f6ebc4f

neeldoshii and others added 3 commits March 1, 2024 01:22

refactor: convert CardBrowserMySearchesDialog to AlertDialog

cff2a28

* Fix : Multiple instance of dialog shown * Simplified the layout, increased padding and touch target * Increased the top and bottom padding * Fix : My search uses divider and fixed padding

Implement reviewer feedback and done reverting on Note.Info.kt file

d47d9d0

Revert "Implement reviewer feedback and done reverting on Note.Info.k…

12a6787

…t file" This reverts commit f5d1017.

github-actions bot added the Has Conflicts label Mar 3, 2024

awanishyadav967 closed this by deleting the head repository Mar 8, 2024

awanishyadav967 mentioned this pull request Mar 8, 2024

#13282 #15704: Fixes Android Studio Warnings under Kotlin Header #15815

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#13282: Fixes Android Studio Warnings under Kotlin Header #15704

#13282: Fixes Android Studio Warnings under Kotlin Header #15704

awanishyadav967 commented Feb 28, 2024

welcome bot commented Feb 28, 2024

david-allison left a comment

david-allison Feb 28, 2024 •

edited

Loading

david-allison Feb 28, 2024

awanishyadav967 commented Feb 28, 2024

david-allison left a comment

david-allison Feb 28, 2024

awanishyadav967 Feb 29, 2024

david-allison Feb 29, 2024

david-allison Feb 28, 2024

david-allison Feb 28, 2024

neeldoshii commented Feb 29, 2024

awanishyadav967 commented Feb 29, 2024

david-allison commented Feb 29, 2024

awanishyadav967 commented Feb 29, 2024

neeldoshii commented Feb 29, 2024

david-allison commented Feb 29, 2024

awanishyadav967 commented Feb 29, 2024

neeldoshii commented Mar 2, 2024

neeldoshii commented Mar 8, 2024

awanishyadav967 commented Mar 8, 2024

awanishyadav967 commented Mar 8, 2024

#13282: Fixes Android Studio Warnings under Kotlin Header #15704

#13282: Fixes Android Studio Warnings under Kotlin Header #15704

Conversation

awanishyadav967 commented Feb 28, 2024

Description

Fixes

Approach

How Has This Been Tested?

Before

After

Checklist

welcome bot commented Feb 28, 2024

david-allison left a comment

Choose a reason for hiding this comment

david-allison Feb 28, 2024 • edited Loading

Choose a reason for hiding this comment

david-allison Feb 28, 2024

Choose a reason for hiding this comment

awanishyadav967 commented Feb 28, 2024

david-allison left a comment

Choose a reason for hiding this comment

david-allison Feb 28, 2024

Choose a reason for hiding this comment

awanishyadav967 Feb 29, 2024

Choose a reason for hiding this comment

david-allison Feb 29, 2024

Choose a reason for hiding this comment

david-allison Feb 28, 2024

Choose a reason for hiding this comment

david-allison Feb 28, 2024

Choose a reason for hiding this comment

neeldoshii commented Feb 29, 2024

awanishyadav967 commented Feb 29, 2024

david-allison commented Feb 29, 2024

awanishyadav967 commented Feb 29, 2024

neeldoshii commented Feb 29, 2024

david-allison commented Feb 29, 2024

awanishyadav967 commented Feb 29, 2024

neeldoshii commented Mar 2, 2024

neeldoshii commented Mar 8, 2024

awanishyadav967 commented Mar 8, 2024

awanishyadav967 commented Mar 8, 2024

david-allison Feb 28, 2024 •

edited

Loading