Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13282 #15704: Fixes Android Studio Warnings under Kotlin Header #15815

Merged
merged 1 commit into from
Mar 9, 2024
Merged

#13282 #15704: Fixes Android Studio Warnings under Kotlin Header #15815

merged 1 commit into from
Mar 9, 2024

Conversation

awanishyadav967
Copy link
Contributor

@awanishyadav967 awanishyadav967 commented Mar 8, 2024

Description

This PR aims to address the feedback provided by the reviewer in PR #15704. It incorporates necessary changes to meet the review comments and enhance the code quality accordingly.

Fixes

Approach

In this PR, the Android Studio warnings have been resolved to enhance the codebase's cleanliness.

How Has This Been Tested?

I tested these changes on Level 30 (Android 11).

Learning

For additional details, refer to PR #15704

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge cleanup Non functional change that would improve the code readability labels Mar 8, 2024
@neeldoshii
Copy link
Contributor

Looks Good!!!

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Mar 9, 2024
@lukstbit lukstbit added this pull request to the merge queue Mar 9, 2024
Merged via the queue into ankidroid:main with commit 7858251 Mar 9, 2024
10 checks passed
@github-actions github-actions bot added this to the 2.18 release milestone Mar 9, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 9, 2024
@awanishyadav967 awanishyadav967 deleted the feature-branch1 branch March 11, 2024 18:55
Copy link
Contributor

Hi there @awanishyadav967! This is the OpenCollective Notice for PRs merged from 2024-03-01 through 2024-03-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non functional change that would improve the code readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants