Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13282: Fixes Android Studio Warnings under Kotlin Header #15704

Closed
wants to merge 15 commits into from
Closed

#13282: Fixes Android Studio Warnings under Kotlin Header #15704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9ca8096
#13282: Fixes Android Studio Warnings under Kotlin Header
awanishyadav967 Feb 28, 2024
b463397
Address reviewer comments
awanishyadav967 Feb 28, 2024
b05e140
fix: image occlusion cards couldn't be previewed in the note editor
BrayanDSO Feb 26, 2024
4555db2
fix: Don't enable the shortcuts unless file access is given
criticalAY Feb 27, 2024
8b223da
Updated strings from Crowdin
Feb 28, 2024
4c23353
chore(logs): log buildResponse failure
david-allison Feb 27, 2024
fe19c9f
fix: error on POST request if app is backgrounded
david-allison Feb 27, 2024
7e60018
Show toast when importing without the app being started at least once
lukstbit Feb 27, 2024
714c271
feat: add summary and help icon to `User actions`
BrayanDSO Feb 24, 2024
a7cf8be
Enhance explicit API compliance, revert specific files
awanishyadav967 Feb 29, 2024
cb5b5a4
test: ignore NoteEditorIntentTest in CI
mikehardy Feb 28, 2024
f6ebc4f
Updated strings from Crowdin
Feb 28, 2024
cff2a28
refactor: convert CardBrowserMySearchesDialog to AlertDialog
neeldoshii Feb 7, 2024
d47d9d0
Implement reviewer feedback and done reverting on Note.Info.kt file
awanishyadav967 Feb 29, 2024
12a6787
Revert "Implement reviewer feedback and done reverting on Note.Info.k…
awanishyadav967 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,7 +1224,6 @@ open class DeckPicker :
}
}

// onBackPressed
@Deprecated("Deprecated in Java")
override fun onBackPressed() {
val preferences = baseContext.sharedPrefs()
Expand Down
1 change: 0 additions & 1 deletion AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckSelectionDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ open class DeckSelectionDialog : AnalyticsDialogFragment() {
isCancelable = true
}

// Material dialog neutral button deprecation
override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
val dialogView = LayoutInflater.from(activity)
.inflate(R.layout.deck_picker_dialog, null, false)
Expand Down
2 changes: 1 addition & 1 deletion AnkiDroid/src/main/java/com/ichi2/libanki/backend/model/NoteUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ fun Note.toBackendNote(): anki.notes.Note {
id = note.id
guid = note.guId!!
notetypeId = note.mid
mtimeSecs = note.mod // this is worrying, 2038 problem
mtimeSecs = note.mod
usn = note.usn
tags.addAll(note.tags.asIterable())
fields.addAll(note.fields.asIterable())
Expand Down
6 changes: 3 additions & 3 deletions api/src/main/java/com/ichi2/anki/FlashCardsContract.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ import com.ichi2.anki.api.BuildConfig
* --------------------------------------------------------------------------------------------------------------------
* ```
*/
object FlashCardsContract {
const val AUTHORITY: String = BuildConfig.AUTHORITY
const val READ_WRITE_PERMISSION: String = BuildConfig.READ_WRITE_PERMISSION
public object FlashCardsContract {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

all the files in api should be reverted

public const val AUTHORITY: String = BuildConfig.AUTHORITY
public const val READ_WRITE_PERMISSION: String = BuildConfig.READ_WRITE_PERMISSION

/**
* A content:// style uri to the authority for the flash card provider
Expand Down