Fix:updating an user with empty username and name gives an error message #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashikaqureshi
force-pushed
the
update_user
branch
from
f8c5f94 to
e72328f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #695 +/- ##
===========================================
+ Coverage 95.84% 95.86% +0.02%
===========================================
Files 95 95
Lines 5200 5230 +30
===========================================
+ Hits 4984 5014 +30
Misses 216 216
|
rashikaqureshi
force-pushed
the
update_user
branch
from
3924d92 to
767d7de
Compare
rashikaqureshi
force-pushed
the
update_user
branch
from
ddc91b4 to
9e16dec
Compare
rashikaqureshi
force-pushed
the
update_user
branch
2 times, most recently
from
7c5a31b to
266c429
Compare
vj-codes
added
the
Status: Needs Review
|
@anitab-org/coding-team This PR needs review. Thanks! |
SanketDG
suggested changes
Aug 31, 2020
| if data["name"]: | ||
| user.name = data["name"] | ||
| else: | ||
| return messages.NAME_FIELD_IS_MISSING,HTTPStatus.OK |
There was a problem hiding this comment.
I'd rewrite this as:
try:
user.name = data["name"]
except KeyError:
return ....
|
@rashikaqureshi please do the changes as requested |
|
@rashikaqureshi Closing the PR due to no update response and inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while updating user details if the username or name is empty. then added an error message.
Fixes #598
Tested these scenarios. Earlier for these scenarios error message was - user was updated successfully.
Now populating a different error message. Hence receiving errors.
Code/Quality Assurance Only
Code/Quality Assurance Only