Fix:updating an user with empty username and name gives an error message

app/api/dao/user.py

@@ -214,6 +214,7 @@ def update_user_profile(user_id: int, data: Dict[str, str]):
             return messages.USER_DOES_NOT_EXIST, HTTPStatus.NOT_FOUND
 
         username = data.get("username", None)
+
         if username:
             user_with_same_username = UserModel.find_by_username(username)
 
@@ -223,8 +224,17 @@ def update_user_profile(user_id: int, data: Dict[str, str]):
 
             user.username = username
 
-        if "name" in data and data["name"]:
-            user.name = data["name"]
+        if "name" in data:
+            if data["name"]:
+                user.name = data["name"]
+            else:
+                return messages.NAME_FIELD_IS_MISSING,HTTPStatus.OK
+
+        if "username" in data:
+            if data["username"]:
+                user.username = data["username"]
+            else:
+                return messages.USERNAME_FIELD_IS_MISSING,HTTPStatus.OK
 
         if "bio" in data:
             if data["bio"]:
@@ -291,7 +301,7 @@ def update_user_profile(user_id: int, data: Dict[str, str]):
 
         if "available_to_mentor" in data:
             user.available_to_mentor = data["available_to_mentor"]
-
+        
         user.save_to_db()
 
         return messages.USER_SUCCESSFULLY_UPDATED, HTTPStatus.OK

app/api/validations/user.py

@@ -1,4 +1,5 @@
 from app import messages
+from http import HTTPStatus
 from app.utils.validation_utils import (
     is_name_valid,
     is_email_valid,
@@ -213,7 +214,7 @@ def validate_update_profile_request_data(data):
 
     if "available_to_mentor" in data and data["available_to_mentor"] is None:
         return messages.FIELD_AVAILABLE_TO_MENTOR_IS_INVALID
-
+    
     return {}
 
 

app/messages.py

@@ -48,6 +48,7 @@
 DESCRIPTION_FIELD_IS_MISSING = {"message": "Description field is missing."}
 COMMENT_FIELD_IS_MISSING = {"message": "Comment field is missing."}
 USERNAME_FIELD_IS_EMPTY = {"message": f"The username field has to be longer than {USERNAME_MIN_LENGTH} characters and shorter than {USERNAME_MAX_LENGTH} characters."}
+USER_AND_USERNAME_FIELD_IS_MISSING ={"message":"The name and username fields are missing."}
 
 # Admin
 USER_IS_ALREADY_AN_ADMIN = {"message": "User is already an Admin."}