Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating an user with empty username and name should give an error message #598

Open
faznan3nazer opened this issue May 17, 2020 · 22 comments
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers.

Comments

@faznan3nazer
Copy link
Contributor

When updating an user with empty username and name should give an error message.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'User-update user profile'.

  2. Provide authorization access token.

  3. {
    "name": "",
    "username": "",
    "bio": "string",
    "location": "string",
    "occupation": "string",
    "organization": "string",
    "slack_username": "string",
    "social_media_links": "string",
    "skills": "string",
    "interests": "string",
    "resume_url": "string",
    "photo_url": "string",
    "need_mentoring": true,
    "available_to_mentor": true
    }

  4. Click on 'Execute'.

  5. Scroll down to 'Responses'.

Screenshot (75)
7. current user's detail after update in" Return details of current user".
Screenshot (76)

Expected behavior
If the username and name are not expected to be updated to empty string and error should be shown.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser chrome
@evangelisilva evangelisilva added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. First Timers Only Good for newcomers. labels May 23, 2020
@rashikaqureshi
Copy link
Contributor

Hi is this bug still open. I want to work on this.

@Sheetalsingh23
Copy link

I would like to work on this issue.

@isabelcosta
Copy link
Member

@rashikaqureshi sorry for the late reply do you still want to work on this?

@rashikaqureshi
Copy link
Contributor

@isabelcosta yes.

@isabelcosta
Copy link
Member

yey! I will assign this to you then @rashikaqureshi :)

@Aaishpra
Copy link
Member

@isabelcosta @devkapilbansal I don't see any updates on the PR by the current assignee so, can I work on this?

@devkapilbansal
Copy link
Member

@Aaishpra please wait for some more time for the assignee to respond. As the PR is complete and needs some minor merge conflicts only

@Aaishpra
Copy link
Member

@Aaishpra please wait for some more time for the assignee to respond. As the PR is complete and needs some minor merge conflicts only

No problem, The pr is already 5 months old that's why i asked.

@rashikaqureshi can you solve the conflicts.

@devkapilbansal
Copy link
Member

I tag the assignee again. If the assignee doesn't respond within two-three days then this issue can be assigned to you

@devkapilbansal
Copy link
Member

@Aaishpra please tag the team on zulip and asked for this issue. This issue will be assigned to you then.
Cc:- @vj-codes

@vj-codes
Copy link
Member

@Aaishpra hey I will be closing the linked PR due to inactivity and the issue will be available again , however it's a first timers only issue and unfortunately you can't be assigned to this .
Do comment on any other issue you would like to work on:)
cc: @devkapilbansal

@Aaishpra
Copy link
Member

Aaishpra commented Jan 1, 2021

@Aaishpra hey I will be closing the linked PR due to inactivity and the issue will be available again , however it's a first timers only issue and unfortunately you can't be assigned to this .
Do comment on any other issue you would like to work on:)
cc: @devkapilbansal

Sure, No problem

@surbhigoel191
Copy link
Contributor

I would like to work on this issue.

@NenadPantelic
Copy link
Contributor

HI @isabelcosta , @vj-codes 👋. I would like to take on this?

@vj-codes
Copy link
Member

vj-codes commented Jan 8, 2021

@surbhigoel191 @NenadPantelic this is a first timers only issue and both of you have already made your first contributions so unfortunately this can't be assigned to you .
Do go through other issues and comment :)

@battuAshita
Copy link
Contributor

battuAshita commented Jan 15, 2021

Hi @isabelcosta @vj-codes I would like to work on this issue.
Can this issue be assigned to me?

@devkapilbansal
Copy link
Member

@battuAshita this issue is for *First TImers Only` and since you have already made a PR. You can't work on this issue. Go through other issues

@battuAshita
Copy link
Contributor

@battuAshita this issue is for *First TImers Only` and since you have already made a PR. You can't work on this issue. Go through other issues

Ok:)

@devkapilbansal
Copy link
Member

devkapilbansal commented Mar 20, 2021

May be this issue was resolved earlier 🤔
Removing Available for now.

@devkapilbansal devkapilbansal removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 20, 2021
@mariejp
Copy link

mariejp commented Apr 14, 2022

I mentioned this issue under a different issue, but I would like to be assigned this issue instead of #673 if possible!

@epicadk
Copy link
Member

epicadk commented Apr 15, 2022

As @devkapilbansal mentioned it might have been resolved earlier so if you could first check if this is still reproducible that would be great : ).

@mariejp
Copy link

mariejp commented Apr 23, 2022

Hi! I did notice that the Pull Request had already gone through for this issue so I instead began working on #685 ! I created a pull request here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers.
Projects
None yet