Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move repo references from lyft -> amundsen #51

Merged
merged 1 commit into from
Aug 19, 2020
Merged

chore: move repo references from lyft -> amundsen #51

merged 1 commit into from
Aug 19, 2020

Conversation

dorianj
Copy link
Contributor

@dorianj dorianj commented Aug 19, 2020

ref: amundsen-io/amundsen#615
I left the CI badges: they're wrong after the GH actions transition because they
refer to Travis, but they need to be fixed properly separately

Signed-off-by: Dorian Johnson 2020@dorianj.net

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

I left the CI badges: they're wrong after the GH actions transition because they
refer to Travis, but they need to be fixed properly separately

Signed-off-by: Dorian Johnson <2020@dorianj.net>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this!!

@feng-tao feng-tao merged commit cdb8028 into amundsen-io:master Aug 19, 2020
@feng-tao
Copy link
Member

thanks @dorianj !

jerryzhu2007 pushed a commit to kylg/amundsencommon that referenced this pull request Aug 20, 2020
* commit 'cdb8028001eaab91bcaf34a6d7b68fc1b318ea5d':
  chore: move repo references from lyft -> amundsen (amundsen-io#51)
  feat: add github action for test and pypi publish (amundsen-io#47)
  ci: add dependabot config (amundsen-io#50)
  ci: move stale yml file to correct dir (amundsen-io#49)
  ci: test pypi travis setting (amundsen-io#48)
  chore: apply license headers to all the source files (amundsen-io#41)
  Update version to pick up report url changes

# Conflicts:
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants