Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply license headers to all the source files #41

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

feng-tao
Copy link
Member

Summary of Changes

Per email discussions

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #41 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   73.27%   73.50%   +0.22%     
==========================================
  Files           6        6              
  Lines         116      117       +1     
  Branches        8        8              
==========================================
+ Hits           85       86       +1     
  Misses         26       26              
  Partials        5        5              
Impacted Files Coverage Δ
amundsen_common/log/action_log.py 85.71% <ø> (ø)
amundsen_common/log/action_log_callback.py 62.50% <ø> (+0.96%) ⬆️
amundsen_common/log/action_log_model.py 92.85% <ø> (ø)
amundsen_common/log/auth_caller_retrieval.py 0.00% <ø> (ø)
amundsen_common/log/caller_retrieval.py 80.00% <ø> (ø)
...mundsen_common/log/http_header_caller_retrieval.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea1e5e...60e33f0. Read the comment docs.

@feng-tao feng-tao merged commit 14d02a9 into master Jul 16, 2020
@feng-tao feng-tao deleted the tfeng_apply_header branch July 16, 2020 17:50
jerryzhu2007 pushed a commit to kylg/amundsencommon that referenced this pull request Aug 20, 2020
* commit 'cdb8028001eaab91bcaf34a6d7b68fc1b318ea5d':
  chore: move repo references from lyft -> amundsen (amundsen-io#51)
  feat: add github action for test and pypi publish (amundsen-io#47)
  ci: add dependabot config (amundsen-io#50)
  ci: move stale yml file to correct dir (amundsen-io#49)
  ci: test pypi travis setting (amundsen-io#48)
  chore: apply license headers to all the source files (amundsen-io#41)
  Update version to pick up report url changes

# Conflicts:
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants